feat: Increase VendorField Size - #84
Merged
faustbrian merged 3 commits intoMay 21, 2019
Merged
Conversation
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
May 20, 2019 22:24
|
The ci/circleci: build-linux-default job is failing as of e7c2a2c85f24da6510b839cd122c7ecf8a9edc2c. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR supports the change in vendorField size from 64 bytes to 255 bytes in Core v2.4.
Specifically:
transaction.cpp: update vendorField handling.This also addresses #82
Types of changes
Checklist