style: Improve Formatting and Maintainability - #98
Merged
faustbrian merged 7 commits intoMay 29, 2019
Merged
Conversation
This PR improves code formatting and maintainability. Specifically, this PR does the following: - fixes exit statement in circleci/clang_tidy.sh. - removes empty space in circleCI config. - fixes dirname statement in ARDUINO_IDE.sh. - updates formatting in src/ and test/ classes. - increases codecoverage. - updates change log. tools used for analysis: - Clang-Tidy - CodeFactor - CodeCov
improves tests for: - AbstractNetwork. - Crypto_Helpers. - Transaction.
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
May 29, 2019 02:39
Codecov Report
@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
+ Coverage 87.28% 91.14% +3.86%
===========================================
Files 27 27
Lines 739 836 +97
===========================================
+ Hits 645 762 +117
+ Misses 94 74 -20
Continue to review full report at Codecov.
|
faustbrian
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves code formatting and maintainability.
Specifically, this PR does the following:
tools used for analysis:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
The PR fulfills these requirements:
developbranch, not themasterbranch