feat(starknet): add support for maintenance mode - #424
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
kwiss
approved these changes
Aug 28, 2024
kwiss
reviewed
Aug 28, 2024
Comment on lines
+43
to
+62
| trait IMaintenance<T> { | ||
| fn is_enabled(self: @T) -> bool; | ||
| fn enable(ref self: T, enable: bool); | ||
| } |
Contributor
There was a problem hiding this comment.
could we use a more descriptive function name here ? like set_maintenance_mode
Contributor
Author
There was a problem hiding this comment.
Updated:
#[starknet::interface]
trait IMaintenance<T> {
fn is_in_maintenance(self: @T) -> bool;
fn set_maintenance_mode(ref self: T, on: bool);
}
ptisserand
force-pushed
the
feature/dev-720-executor-maintenance-mode
branch
from
August 28, 2024 13:52
efca109 to
0567cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for maintenance mode, when
executoris disabled, the following functions will revert:create_ordercancel_orderexecute_orderfulfill_orderHere is the interface for maintenance mode:
IMaintenance::enablecan only be invoked byadminWhat type of PR is this? (check all applicable)
feat:)fix:)docs:)style:)refactor:)perf:)test:)build:)ci:)chore:)revert:)BREAKING CHANGE:)Related Tickets & Documents
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
PR Title and Description Guidelines:
feat:,fix:,chore:,BREAKING CHANGE:etc. in your PR title.Closing Issues