Skip to content

feat(executor): add get_fees_amount view - #429

Merged
ptisserand merged 1 commit into
mainfrom
feature/dev-696-missing-listing-fees-in-api
Aug 28, 2024
Merged

ptisserand merged 1 commit into
mainfrom
feature/dev-696-missing-listing-fees-in-api

Conversation

@ptisserand

Copy link
Copy Markdown
Contributor

Description

Add get_fees_amount to retrieve fees for a given token:

struct FeesAmount {
    fulfill_broker: u256,
    listing_broker: u256,
    ark: u256,
    creator: u256,
}

    fn get_fees_amount(
        self: @T,
        fulfill_broker: ContractAddress,
        listing_broker: ContractAddress,
        nft_address: ContractAddress,
        nft_token_id: u256,
        payment_amount: u256
    ) -> FeesAmount;

What type of PR is this? (check all applicable)

  • 🍕 Feature (feat:)
  • 🐛 Bug Fix (fix:)
  • 📝 Documentation Update (docs:)
  • 🎨 Style (style:)
  • 🧑‍💻 Code Refactor (refactor:)
  • 🔥 Performance Improvements (perf:)
  • ✅ Test (test:)
  • 🤖 Build (build:)
  • 🔁 CI (ci:)
  • 📦 Chore (chore:)
  • ⏩ Revert (revert:)
  • 🚀 Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Documentation
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

@linear

linear Bot commented Aug 27, 2024

Copy link
Copy Markdown

@changeset-bot

changeset-bot Bot commented Aug 27, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c9ee8f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ptisserand
ptisserand requested a review from kwiss August 27, 2024 17:43
@ptisserand
ptisserand merged commit 945c726 into main Aug 28, 2024
@ptisserand
ptisserand deleted the feature/dev-696-missing-listing-fees-in-api branch August 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants