Skip to content

feat(test): fix core and react test issues - #459

Merged
gershon merged 5 commits into
feat/contract-v2from
feature/dev-819-fix-v2-core-tests-issues
Sep 24, 2024
Merged

gershon merged 5 commits into
feat/contract-v2from
feature/dev-819-fix-v2-core-tests-issues

Conversation

@gershon

@gershon gershon commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

Description

  • fix cyclic dependency between @ark-project/core and @ark-project/test
  • use vitest for core tests (already used for react tests)

What type of PR is this? (check all applicable)

  • 🍕 Feature (feat:)
  • 🐛 Bug Fix (fix:)
  • 📝 Documentation Update (docs:)
  • 🎨 Style (style:)
  • 🧑‍💻 Code Refactor (refactor:)
  • 🔥 Performance Improvements (perf:)
  • ✅ Test (test:)
  • 🤖 Build (build:)
  • 🔁 CI (ci:)
  • 📦 Chore (chore:)
  • ⏩ Revert (revert:)
  • 🚀 Breaking Changes (BREAKING CHANGE:)

@linear

linear Bot commented Sep 18, 2024

Copy link
Copy Markdown

@changeset-bot

changeset-bot Bot commented Sep 18, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4232235

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gershon
gershon requested a review from kwiss September 18, 2024 16:53

@kwiss kwiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't use environment variables for accounts but instead use a config file that goes with our testing environment. It looks like we'll use Starknet devnet instead of Dojo Katana, so in that regard, we can use their seed with a specific value so anyone using the seed can run the tests.

@gershon
gershon merged commit dae2498 into feat/contract-v2 Sep 24, 2024
@gershon
gershon deleted the feature/dev-819-fix-v2-core-tests-issues branch September 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants