Remove dead code with no production callers#10
Merged
Conversation
Delete six functions/classes that were unreachable from any CLI entry point and kept alive only by their own tests: - config_builder.build_transcription_config / build_streaming_params: redundant wrappers; commands call merge_*()+construct_*() directly. - auth.ams.get_auth: superseded; the login flow reads the account from exchange()'s response instead of a second GET /v1/auth round-trip. - agent.audio.Player (and its now-orphaned _default_output_stream factory): superseded by DuplexAudio / _DuplexPlayer. - config.set_active_profile: no caller; the active profile is set via set_api_key(). - environments.known(): no caller. Tests that exercised unique behavior (layer precedence, the coercion matrix, the translate payload, the exchange-account path) are rerouted through the real production code paths rather than dropped, so coverage holds at 94%.
alexkroman
pushed a commit
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete six functions/classes that were unreachable from any CLI entry point
and kept alive only by their own tests:
redundant wrappers; commands call merge_()+construct_() directly.
exchange()'s response instead of a second GET /v1/auth round-trip.
superseded by DuplexAudio / _DuplexPlayer.
set_api_key().
Tests that exercised unique behavior (layer precedence, the coercion matrix,
the translate payload, the exchange-account path) are rerouted through the
real production code paths rather than dropped, so coverage holds at 94%.