Harden YouTube download fallback to pick the largest landed file#34
Merged
Conversation
When yt-dlp's prepared filename doesn't exist (post-processing changed the extension), download_audio fell back to the first entry from iterdir(), whose order is arbitrary. yt-dlp can leave sidecars (thumbnail, .info.json, a leftover .part fragment) in the destination directory, so the fallback could return a non-audio file that then fails downstream with a confusing decode error. Pick the largest file instead — the decoded audio track dwarfs any metadata sidecar. https://claude.ai/code/session_01QVfdQDhreXWkEHQoArh71E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When yt-dlp's prepared filename doesn't exist (post-processing changed the
extension), download_audio fell back to the first entry from iterdir(), whose
order is arbitrary. yt-dlp can leave sidecars (thumbnail, .info.json, a
leftover .part fragment) in the destination directory, so the fallback could
return a non-audio file that then fails downstream with a confusing decode
error. Pick the largest file instead — the decoded audio track dwarfs any
metadata sidecar.
https://claude.ai/code/session_01QVfdQDhreXWkEHQoArh71E