-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(devtools): migrate DevTools UI to TypeScript #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5608c04
feat: scaffold DevTools web UI
rian-be c40234e
feat: bundle DevTools UI into plugin assembly
rian-be 146a8ea
refactor: templatize DevTools gRPC UI page
rian-be 49b108c
feat: add gRPC DevTools catalog and invocation UI
rian-be 4bd15dc
fix: correct CodeRabbit review profile value
rian-be 5dd83e4
ci: build plugin UIs before solution and plugin publish
rian-be File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| node_modules/ | ||
| dist/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { build, context } from "esbuild"; | ||
| import { mkdir, readFile, writeFile } from "node:fs/promises"; | ||
| import { dirname, join } from "node:path"; | ||
| import { fileURLToPath } from "node:url"; | ||
|
|
||
| /** Marker replaced with the compiled JS bundle inside the HTML template. */ | ||
| const BUNDLE_MARKER = "/*__BUNDLE__*/"; | ||
|
|
||
| const root = dirname(fileURLToPath(import.meta.url)); | ||
| const watch = process.argv.includes("--watch"); | ||
|
|
||
| const options = { | ||
| entryPoints: [join(root, "src", "app.ts")], | ||
| bundle: true, | ||
| format: "iife", | ||
| minify: true, | ||
| target: ["es2020"], | ||
| outfile: join(root, "dist", "bundle.js"), | ||
| }; | ||
|
|
||
| async function inlineBundle() { | ||
| const [template, bundle] = await Promise.all([ | ||
| readFile(join(root, "template.html"), "utf8"), | ||
| readFile(join(root, "dist", "bundle.js"), "utf8"), | ||
| ]); | ||
| const html = template.replace(BUNDLE_MARKER, () => bundle); | ||
| await writeFile(join(root, "dist", "ui.html"), html); | ||
| } | ||
|
|
||
| if (watch) { | ||
| const ctx = await context(options); | ||
| await ctx.watch(); | ||
| await inlineBundle(); | ||
| console.log("Watching for changes…"); | ||
| } else { | ||
| await build(options); | ||
| await inlineBundle(); | ||
| console.log("TypeScript UI written to dist/ui.html"); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Regenerate
ui.htmlafter every watch rebuild.ctx.watch()does not callinlineBundle()for later rebuilds. After the first source change,dist/bundle.jschanges butdist/ui.htmlstill contains the old bundle. Attach the inlining step to esbuild's rebuild completion, or implement watch mode with an explicit rebuild loop.🤖 Prompt for AI Agents