Conversation
Test MySQL backslash escapes with the default SQL mode, since the current driver explicitly rejects NO_BACKSLASH_ESCAPES. Keep assertions for every escape case and expect literal backslashes in quoted identifiers.
JanJakes
force-pushed
the
sqlite-storage
branch
from
September 24, 2026 11:10
8b5567d to
70383ff
Compare
Match the PHPCompatibility target to the existing Composer requirement. The PHP 5.6 target incorrectly rejects supported features such as Throwable and void return types.
JanJakes
force-pushed
the
sqlite-storage
branch
from
September 24, 2026 13:14
70383ff to
1a73811
Compare
Resolve DB_PATH or db-path.php at runtime, retaining FQDB compatibility for older integration plugin versions. Export and table listing check that the database exists before opening it. Import uses the configured location and initializes managed storage only when no location has been recorded. Keep storage initialization out of the plugin loader and cover the storage behavior with Behat scenarios. WordPress/sqlite-database-integration#502
JanJakes
force-pushed
the
sqlite-storage
branch
from
September 24, 2026 13:26
1a73811 to
5824b36
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the SQLite integration plugin's new storage layout while keeping compatibility with older plugin releases.
DB_PATH,db-path.php, or legacyFQDBsettings.Behat covers the storage behavior. Separate commits correct the existing import fixtures for the current driver and align PHP compatibility checks with the project's PHP 7.4 requirement.
Why
These commands run before WordPress loads its database drop-in. With the new storage layout,
FQDBis no longer always defined at that point, so the commands need to resolve the configured database themselves.Related: WordPress/sqlite-database-integration#502, WordPress/sqlite-database-integration#512