Skip to content

SAP Integration Suite: Document update for the custom DCE/DCR names are not supported - #14871

Open
v-krishnachi (v-krishnachi) wants to merge 1 commit into
Azure:masterfrom
v-krishnachi:users/v-krishnachi/sap-integrationsuite-custom-dce-note
Open

SAP Integration Suite: Document update for the custom DCE/DCR names are not supported#14871
v-krishnachi (v-krishnachi) wants to merge 1 commit into
Azure:masterfrom
v-krishnachi:users/v-krishnachi/sap-integrationsuite-custom-dce-note

Conversation

@v-krishnachi

@v-krishnachi v-krishnachi (v-krishnachi) commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Readme document updated for the custom DCE/DCR will not support for SAP connectors.
screenshot below

image

@v-atulyadav v-atulyadav self-assigned this Aug 11, 2026
@v-atulyadav
v-atulyadav requested a lite review from Copilot August 11, 2026 04:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the SAP Integration Suite README to clarify that custom-named DCE/DCR resources are not supported and to document the expected tool-generated naming convention to avoid workspace ID extraction failures.

Changes:

  • Adds an IMPORTANT callout stating custom DCE/DCR names are not supported.
  • Documents the required DCE/DCR naming convention and how {workspace-short-id} is derived.
  • Provides remediation guidance (redeploy and repoint connection to standard resources).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Solutions/SAP/Tools/IntegrationSuite/README.md Outdated
Comment thread Solutions/SAP/Tools/IntegrationSuite/README.md Outdated
@MartinPankraz

Martin Pankraz (MartinPankraz) commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Docs update is a good first step. How about enforcing naming convention on the scripts to avoid readme oversight v-krishnachi (@v-krishnachi) ?

Naming check on this function and code docs should enforce better: https://github.com/v-krishnachi/Azure-Sentinel/blob/294ac3de365f1e9f27325b9e219c979ad1a6d090/Solutions/SAP/Tools/IntegrationSuite/IntegrationSuiteHelpers.ps1#L412

@MartinPankraz

Martin Pankraz (MartinPankraz) commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

v-krishnachi (@v-krishnachi) ran deployment tests with your suggestion, fixed where needed and made a PR towards your origin from your source. Can you pick changes from there? v-krishnachi#1

@v-krishnachi
v-krishnachi (v-krishnachi) force-pushed the users/v-krishnachi/sap-integrationsuite-custom-dce-note branch from 10645bf to c3d9ffd Compare August 13, 2026 15:54
@MartinPankraz

Copy link
Copy Markdown
Contributor

Hey v-krishnachi (@v-krishnachi), the PR suggestion I made was not fully merged. Check the DCE naming convention for instance. ASI_* vs. Microsoft-Sentinel-*. Please take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants