SAP Integration Suite: Document update for the custom DCE/DCR names are not supported - #14871
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the SAP Integration Suite README to clarify that custom-named DCE/DCR resources are not supported and to document the expected tool-generated naming convention to avoid workspace ID extraction failures.
Changes:
- Adds an IMPORTANT callout stating custom DCE/DCR names are not supported.
- Documents the required DCE/DCR naming convention and how
{workspace-short-id}is derived. - Provides remediation guidance (redeploy and repoint connection to standard resources).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Docs update is a good first step. How about enforcing naming convention on the scripts to avoid readme oversight v-krishnachi (@v-krishnachi) ? Naming check on this function and code docs should enforce better: https://github.com/v-krishnachi/Azure-Sentinel/blob/294ac3de365f1e9f27325b9e219c979ad1a6d090/Solutions/SAP/Tools/IntegrationSuite/IntegrationSuiteHelpers.ps1#L412 |
fb6424c to
10645bf
Compare
|
v-krishnachi (@v-krishnachi) ran deployment tests with your suggestion, fixed where needed and made a PR towards your origin from your source. Can you pick changes from there? v-krishnachi#1 |
…custom names not supported)
10645bf to
c3d9ffd
Compare
|
Hey v-krishnachi (@v-krishnachi), the PR suggestion I made was not fully merged. Check the DCE naming convention for instance. ASI_* vs. Microsoft-Sentinel-*. Please take another look. |
Readme document updated for the custom DCE/DCR will not support for SAP connectors.
screenshot below