Skip to content

Fixed threshold value from 50 to 0.5 - #14874

Open
ripping-at-the-siem wants to merge 1 commit into
Azure:masterfrom
ripping-at-the-siem:fix/smb-threshold-0.5
Open

Fixed threshold value from 50 to 0.5#14874
ripping-at-the-siem wants to merge 1 commit into
Azure:masterfrom
ripping-at-the-siem:fix/smb-threshold-0.5

Conversation

@ripping-at-the-siem

Copy link
Copy Markdown

The threshold was originally 50 but the value of "Deviation" from line 40 returns a value from 0 to 1 not 0 to 100.

Required items, please complete

Change(s):

  • Fixed threshold value from 50 to 0.5

Reason for Change(s):

  • Line 40 calculates a value where 1.0 is 100%. Current threshold of 50 will only alert if the Deviation is 5000%.

Version Updated:

  • yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • yes

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


The threshold was originally 50 but the value of "Deviation" from line 40 returns a value from 0 to 1 not 0 to 100.
@ripping-at-the-siem
ripping-at-the-siem requested review from a team as code owners August 10, 2026 20:54
@v-atulyadav v-atulyadav self-assigned this Aug 11, 2026
@v-atulyadav
v-atulyadav requested a lite review from Copilot August 11, 2026 04:24
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Aug 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the anomaly detection rule to use a deviation threshold consistent with the query’s deviation scale (0–1) and bumps the rule version accordingly.

Changes:

  • Changed the deviation threshold from 50 to 0.5 in the KQL query.
  • Updated the analytic rule version from 1.0.0 to 1.0.1.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi ripping-at-the-siem,
Please repackage the solution. Thanks

@ripping-at-the-siem

Copy link
Copy Markdown
Author

v-atulyadav I'm sorry but I don't know what you mean by "repackage the solution". This is my first PR ever.

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi ripping-at-the-siem,
Please refer below link for your reference. Thanks
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/README.md

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi ripping-at-the-siem,
Please let us know if you are facing any difficulties with this process. We’ll be happy to help. Thanks

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi ripping-at-the-siem,
Please let us know if you are facing any difficulties with this process. We’ll be happy to assist. Thanks

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi ripping-at-the-siem,
Please review above comments. Thanks

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi ripping-at-the-siem,
Please let us know if you are facing any difficulties with this process. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants