Show preview version on welcome screen - #193
Open
Mike Krüger (mkrueger) wants to merge 1 commit into
Open
Conversation
Mike Krüger (mkrueger)
requested review from
a team
and
a lite review from Copilot
August 20, 2026 15:24
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a prominent “PREVIEW VERSION” banner to the embedded welcome screen and fills in the runtime display version (consistent with the shell’s display-version contract that strips build metadata), with regression tests to ensure the placeholder is replaced.
Changes:
- Updated the ANSI welcome screen resource to include a preview banner with a
{{VERSION}}placeholder. - Replaced the version placeholder at load-time using
ShellInterpreter.GetDisplayVersion(...)when reading the embedded resource. - Added regression assertions to verify the displayed version is present and the placeholder is not.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CosmosDBShell/cosmos_welcome.ans |
Adds the PREVIEW banner line and {{VERSION}} placeholder to the welcome screen. |
CosmosDBShell/Azure.Data.Cosmos.Shell.Core/WelcomeScreen.cs |
Replaces {{VERSION}} at runtime when loading the embedded ANSI resource. |
CosmosDBShell.Tests/CommandTests/WelcomeCommandTests.cs |
Adds tests to validate version substitution and ensure the placeholder is removed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation