Skip to content

Show preview version on welcome screen - #193

Open
Mike Krüger (mkrueger) wants to merge 1 commit into
mainfrom
dev/mkrueger/welcome-preview-banner
Open

Show preview version on welcome screen#193
Mike Krüger (mkrueger) wants to merge 1 commit into
mainfrom
dev/mkrueger/welcome-preview-banner

Conversation

@mkrueger

Copy link
Copy Markdown
Collaborator

Summary

  • display a prominent PREVIEW VERSION banner on the welcome screen
  • inject the assembly display version at runtime, matching the version command and omitting build metadata
  • clarify that commands, output, and behavior may change before general availability
  • add regression coverage for placeholder replacement and displayed version

Validation

  • dotnet test CosmosDBShell.Tests/CosmosDBShell.Tests.csproj --filter FullyQualifiedName~CosmosShell.Tests.CommandTests.WelcomeCommandTests (5 passed)
  • dotnet build CosmosDBShell/CosmosDBShell.csproj --no-restore
  • dotnet build CosmosDBShell.Tests/CosmosDBShell.Tests.csproj --no-restore

@mkrueger
Mike Krüger (mkrueger) requested review from a team and a lite review from Copilot August 20, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a prominent “PREVIEW VERSION” banner to the embedded welcome screen and fills in the runtime display version (consistent with the shell’s display-version contract that strips build metadata), with regression tests to ensure the placeholder is replaced.

Changes:

  • Updated the ANSI welcome screen resource to include a preview banner with a {{VERSION}} placeholder.
  • Replaced the version placeholder at load-time using ShellInterpreter.GetDisplayVersion(...) when reading the embedded resource.
  • Added regression assertions to verify the displayed version is present and the placeholder is not.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
CosmosDBShell/cosmos_welcome.ans Adds the PREVIEW banner line and {{VERSION}} placeholder to the welcome screen.
CosmosDBShell/Azure.Data.Cosmos.Shell.Core/WelcomeScreen.cs Replaces {{VERSION}} at runtime when loading the embedded ANSI resource.
CosmosDBShell.Tests/CommandTests/WelcomeCommandTests.cs Adds tests to validate version substitution and ensure the placeholder is removed.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit ee8fa0d in the dev/mkrueger/welcome... branch remains at 61%, unchanged from commit 48b107c in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants