Default Error for department #593
Conversation
…hich department should be selected by default. That makes the department match more specific
fritzj2
left a comment
There was a problem hiding this comment.
The issue with the student software developer is not fixed. Seems to work for other jobs with a similar problem (i.e, Facilities management and Residence Halls.
fritzj2
left a comment
There was a problem hiding this comment.
Changes look good.
The reason why the student software developer fails is that it hasn't been implemented on the test data yet. The last backup was before SSDT became its own job, yet TRACY will grab it anyway. This fix means it looks through the database for the position to compare it, but if it cannot find it, it defaults to the first option. This also fixes issue #576
|
@johnlolonga19 hey John this issue is tiny fix so not a problem at all but just to be on the side of precaution to not do this unless you are confident it will work. If you think it will be I would suggest you to ask someone not from your team to merge it after two people have approved not one because this merge doesn't follow proper PR guidelines. |
issue number: #547 Academic Vice Pres/Provost & Dean Default Error #547
Changes:
Updated the adjustment form department default logic to match departments based on both ORG and ACCOUNT, rather than ORG only. This prevents SSDT forms from defaulting to the wrong department when creating an adjustment form.
Testing:
To test this fix, look at what was there in staging and create an LSF form with a department that has a sub-department. After the form is created, open the adjustment form for that same LSF. Check the department dropdown and confirm it defaults to Computer Science-Student Software Development Team instead of Academic Vice Pres/Provost & Dean or the first thing. You can also check this in/home/vscode/lsf/app/controllers/main_routes/alterLSF.py and/home/vscode/lsf/app/templates/main/alterLSF.html. This way, you can see what was changed and added. The biggest thing is that it was only checking for ORG.