Skip to content

Demo data fix dpb#643

Merged
MImran2002 merged 10 commits into
department-portal-basefrom
demoDataFix_dpb
Jul 10, 2026
Merged

Demo data fix dpb#643
MImran2002 merged 10 commits into
department-portal-basefrom
demoDataFix_dpb

Conversation

@conwelld

@conwelld conwelld commented Jul 9, 2026

Copy link
Copy Markdown

Issue Description

Fixes issue regarding demo data not following Brian's variable naming conventions, as well as fixes the semantic errors within allocations as well as added demo data to department-portal-base

  • department-portal-base had no demo data to match the new models in Brian's branch, I added the dummy data from PeeWeeAttribute and fixed the naming conventions to match Brian's I also fixed a database error within the data where allocations called a nonexistent term within Term.termcode. I also fixed the naming of the department members data because its naming was unclear as well as position history

Testing

  • I reset database with no issues and was able to flask run with no issues

Comment thread database/demo_data.py Outdated
Comment thread database/demo_data.py Outdated
Comment thread database/demo_data.py Outdated
Comment thread database/demo_data.py Outdated
@conwelld

conwelld commented Jul 9, 2026

Copy link
Copy Markdown
Author

I believe it should be fixed now

Comment thread database/demo_data.py Outdated
Comment thread database/demo_data.py Outdated
Comment thread database/demo_data.py Outdated

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good test all passed and the demo data looks good

@MImran2002 MImran2002 merged commit 0369e4a into department-portal-base Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants