Fix node saml - #2
Merged
Merged
Conversation
brandonros
approved these changes
May 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: During vigorous unit testing with planted errors in local functions the callback function wrapping a callback function for encryption reported 'callback already called' messages, ingesting the true error source.
Description
The wrapper fo the existing encryption callback function was changed to a promise streamlining code. Errors report perfectly back to the calling application no matter nesting level in saml20.cs.
In addition 2 error checks were added to keep needless processing cycles from occurring
If the XML argument for signing is null, undefined or empty a
'XML to sign cannot be null or empty.'
reference error is thrown keeping the xml parser from failing.
If the assertion argument to be imbedded in the response XML is undefined, null or empty a
'Assertion XML cannot be empty for parsing while creating SAML20 Response.'
reference error is thown keeping the parser from failing.
Testing
mocha
Checklist
This was back tested in node-sso-formatter by unit/e2e with both embedded errors insuring proper return, and 100% testing success.