chore(root): clean up unused code change entries - #1
Merged
Conversation
- Remove empty code change entries from the changes log - Streamline the commit history for better readability
There was a problem hiding this comment.
Pull request overview
This PR updates the web app’s download UX and client-side observability setup, while also bumping several TanStack-related dependencies and introducing a dedicated Vitest config for the app.
Changes:
- Hardened download filename derivation so malformed/relative URLs won’t break the download click path, with regression tests.
- Added centralized Sentry client filtering (ignore/deny lists + beforeSend) and reduced devtools exposure by gating TanStack Devtools to dev builds.
- Updated TanStack package versions (and lockfile) and added
apps/web/vitest.config.tsto keep tests isolated from Vite/Nitro plugin setup.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates lockfile to reflect dependency upgrades (notably TanStack stack + transitive updates). |
| apps/web/vitest.config.ts | Adds Vitest config with @ alias so tests don’t import Nitro/TanStack Start/Sentry build plugins. |
| apps/web/src/utils/packs.ts | Adds resolveDownloadFileName helper to safely derive a.download from possibly malformed/relative URLs. |
| apps/web/src/utils/packs.test.ts | Adds Vitest coverage for filename parsing/decoding and “does not throw” regression cases. |
| apps/web/src/routeTree.gen.ts | Regenerated route tree (ordering/structure changes likely from dependency updates). |
| apps/web/src/routes/__root.tsx | Wraps <TanStackDevtools /> with import.meta.env.DEV so it’s dev-only. |
| apps/web/src/router.tsx | Adds Sentry config: drops BrowserApiErrors, adds ignore/deny lists and beforeSend filtering. |
| apps/web/src/config/sentry.ts | Introduces centralized Sentry filtering configuration and a beforeSend event dropper. |
| apps/web/src/components/pack-selection/SelectedPacks.tsx | Uses resolveDownloadFileName to avoid new URL(...) throwing and aborting downloads. |
| apps/web/package.json | Bumps TanStack dependencies and eslint plugin query version. |
| .mcp.json | Adds an MCP server definition for Sentry. |
Comments suppressed due to low confidence (1)
apps/web/src/config/sentry.ts:65
- This function is typed with
ErrorEvent, but Sentry passes a SentryEventobject intobeforeSend. KeepingErrorEventhere will cause TypeScript errors and can mislead future changes.
export function dropUnactionableEvent(event: ErrorEvent): ErrorEvent | null {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to error reporting, dependency management, download handling, and testing in the web application. The most significant changes include filtering out unactionable Sentry errors, updating TanStack dependencies, improving download file name resolution, and adding a dedicated Vitest configuration.
Error reporting improvements:
sentry.tsto filter out errors from third-party scripts and browser extensions, ignore unactionable events, and prevent reporting errors without usable stack traces. This configuration is integrated into Sentry initialization inrouter.tsx. [1] [2] [3].mcp.jsonfor Sentry MCP server configuration.Dependency updates:
@tanstackdependencies to their latest versions inpackage.jsonto keep the codebase current and benefit from bug fixes and improvements. [1] [2]Download handling improvements:
resolveDownloadFileNameinpacks.ts, updating its usage inSelectedPacks.tsx, and adding comprehensive tests inpacks.test.ts. This ensures robust handling of various URL formats and edge cases. [1] [2] [3] [4]Testing setup:
vitest.config.tsto configure module aliasing and test environment, separating test configuration from the main Vite build.Other changes:
routeTree.gen.tsfor improved consistency and type safety. [1] [2] [3]__root.tsx. [1] [2]