-
Notifications
You must be signed in to change notification settings - Fork 0
fix: stabilize sheet focus and dom contract #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
02ce93e
bbc16cc
c2494b3
864f738
4bd3630
f33a824
a5de573
5aec89d
b5f8959
70814a8
7cd9d42
04d07f2
a1cf29a
0aaf441
d0b988a
61d9ba1
8c179aa
a401258
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,6 +142,7 @@ describe("ClinicalDashboard merge-artifact guards", () => { | |
| expect(clinicalDashboardSource).toContain("resolveMobileComposerReserve("); | ||
| expect(clinicalDashboardSource).toContain('from "@/components/clinical-dashboard/mobile-composer-reserve"'); | ||
| expect(clinicalDashboardSource).not.toContain('bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"'); | ||
| expect(clinicalDashboardSource).not.toMatch(/pb-\[max\([^"']*safe-area-inset-bottom/); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When AGENTS.md reference: AGENTS.md:L216-L218 Useful? React with 👍 / 👎. |
||
| expect(clinicalDashboardSource).toContain( | ||
| '"max-sm:pb-[var(--mobile-composer-reserve)] max-sm:[scroll-padding-bottom:var(--mobile-composer-reserve)] sm:mb-24"', | ||
| ); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: BigSimmo/Database
Length of output: 10359
🏁 Script executed:
Repository: BigSimmo/Database
Length of output: 33149
🏁 Script executed:
Repository: BigSimmo/Database
Length of output: 10681
🌐 Web query:
Tailwind CSS v4 important modifier trailing exclamation mark utility syntax max-h-[88dvh]!💡 Result:
In Tailwind CSS v4, the syntax for marking a utility as important has changed. You must now place the exclamation mark (!) at the end of the class name, rather than at the beginning [1][2]. For your specific case, the correct syntax is: max-h-[88dvh]! Key details regarding this change: - New Placement: The! modifier is now a suffix [1]. For example, a class like!text-blue-500 (v3 style) should be updated to text-blue-500! (v4 style) [1][2]. - Compatibility: While Tailwind v4 still supports the older prefix syntax (e.g.,!text-blue-500) for backwards compatibility, it is officially deprecated and you are encouraged to migrate to the suffix syntax [1]. - Arbitrary Values: The syntax for arbitrary values (square brackets) remains compatible with this modifier. Placing the! after the closing bracket correctly applies!important to the generated CSS rule [1][2]. - Global Important: If you intended to make all utilities important, the v4 approach is to use the important flag in your CSS import directive rather than the tailwind.config.js file [3][4]:
@import"tailwindcss" important;Citations:
importantin v4 tailwindlabs/tailwindcss#14448🏁 Script executed:
Repository: BigSimmo/Database
Length of output: 728
Recognize Tailwind v4 trailing
!important modifier. These checks miss classes likemax-h-[88dvh]!andsm:max-h-[min(80dvh,36rem)]!, so the Sheet can still append its default cap when callers mark their height utility important. Accept the suffix form and add a regression test.🤖 Prompt for AI Agents