Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
41b02a0
Add phone category-filter design study mockups
cursoragent Aug 4, 2026
7a9239e
Show open/selected states in category filter mockups
cursoragent Aug 4, 2026
3557862
Merge branch 'main' into cursor/category-filter-mockups-8e31
BigSimmo Aug 4, 2026
5a98a20
Replace phone filter select with soft value button
cursoragent Aug 4, 2026
dc2505b
Merge branch 'cursor/category-filter-mockups-8e31' of https://github.…
cursoragent Aug 4, 2026
79e615d
Merge branch 'main' into cursor/category-filter-mockups-8e31
BigSimmo Aug 5, 2026
7aee288
fix(ui): keep phone filter trigger lint-clean and rail-aligned
BigSimmo Aug 5, 2026
af4adbc
fix(ui): harden MobileResultFilterControl review findings
cursoragent Aug 5, 2026
055e794
fix(ui): satisfy React purity lint for mobile filter control
cursoragent Aug 5, 2026
0d7dc4c
fix(ui): ignore modifier chords in phone filter typeahead
cursoragent Aug 5, 2026
65c62dc
docs: record PR #1606 babysit review at 0d7dc4c0
cursoragent Aug 5, 2026
edfcab5
fix(ui): tighten phone filter geometry and mockup counts
cursoragent Aug 5, 2026
a2dd13e
docs: supersede PR #1606 babysit ledger at edfcab5e
cursoragent Aug 5, 2026
20a71e8
fix(ui): let Safari close phone filter by tapping the trigger
cursoragent Aug 5, 2026
7ac98f7
fix(ui): restore trigger focus when closing phone filter by click
cursoragent Aug 5, 2026
2632fca
fix(ui): finish MobileResultFilterControl review gaps
cursoragent Aug 5, 2026
9f44520
Merge remote tip and keep phone-filter review gap fixes
cursoragent Aug 5, 2026
bf54a70
fix(ui): ignore disabled filter taps and keep typeahead non-swallowing
cursoragent Aug 5, 2026
bccd3ba
merge origin/main: keep soft Category filter menu
cursoragent Aug 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/branch-review-ledger.md
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,9 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie
| 2026-08-04 | claude/top-search-design-mockups-w53znc | b432448e4893a42d07558aff0dc04be797971231 | PR #1611 — results-band shelf Clear filter-only, memo deps, restored tests | Fixed two Qodo findings from merged #1555; mutation-tested guard added | tsc 0; eslint 0; vitest 4 files/59 tests; verify:pr-local blocked by lock parity (node 24.13 vs jsdom@30) |
| 2026-08-04 | claude/search-bar-decisions-doc | a7dea7f777255ade72878820a636413aaf9588af | search-bar handoff doc replacement + review fixes | Docs-only review fixes: mode/shelf accounting, Sort consumers, #230/#170 precision; removed unquoted-output claim from prior row | prettier --check . ; check:outstanding-issues ; docs:check-links ; docs:check-index |
| 2026-08-04 | claude/search-bar-decisions-doc | 3b4cd6e6bf1f36fb8aff098ce7d333641e0859d3 | search-bar handoff doc replacement + review fixes | Fixed CodeRabbit/Codex findings; Bugbot hosted stuck queued, local Bugbot-equivalent confirmed two P2 doc errors and rejected sheets-are-target finding. verify:pr-local PASS (docs scope). Decisive: prettier All matched files use Prettier code style!; outstanding-issues 228 rows next-id=231; docs link check passed: 1615; docs/codebase-index coverage OK | verify:pr-local (docs); prettier --check; check:outstanding-issues; docs:check-links; docs:check-index; check:branch-review-ledger |
| 2026-08-04 | codex/fix-mode-switching-and-loading-issues | 3e3b224a2ec13928d1e28173b1fc4c75d202d7d2 | PR #1607 unblock/fix | clean — behind 0, merge-tree clean, 0 unresolved threads, required CI in progress (no code fix) | merge-tree clean; behind_by 0; Unit/Build/Static/ProdUI in progress; no failing required |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve ledger rows in place

This added row is the same codex/fix-mode-switching-and-loading-issues record that the diff removes from its previous position below, so the commit is rewriting/moving existing ledger history instead of only appending the two new cursor/category-filter-mockups-8e31 records. For ledger updates, keep existing rows byte-for-byte in place and append new records only; otherwise future syncs/reviews lose the append-only audit trail this file relies on.

AGENTS.md reference: AGENTS.md:L145-L145

Useful? React with 👍 / 👎.

| 2026-08-05 | cursor/category-filter-mockups-8e31 | 0d7dc4c0ec3eb0c82c70a23a274e25083773a612 | PR #1606 babysit: typeahead modifier chords + typeahead timer cleanup; resolve remaining review threads | clean | vitest search-results-header-band.dom.test.tsx 30 passed; eslint changed files clean; 0 unresolved review threads |
| 2026-08-05 | cursor/category-filter-mockups-8e31 | edfcab5e8889c76ac91de3a78fdf1fad21aa19f6 | PR #1606 babysit: filter geometry, rail typography, mockup counts, off-screen close | clean | vitest search-results-header-band.dom.test.tsx 31 passed; eslint changed files clean |
| 2026-08-04 | codex/v2-design-system-phase1-accessibility | 7e19964973f38c769ca725d6d53aff088ed182b3 | V2 Phase 1 Lane B accessibility tables announcements document preview | approved after rapid retry announcement identity fix | focused Vitest 35p + follow-up 15p; typecheck PASS; independent review clean |
| 2026-08-04 | codex/v2-design-system-phase1-truth | 1980f155f9467707574a45c6338a22f3457b0d7e | V2 Phase 1 Lane A adoption truth design-sync parity documentation contracts | approved after dynamic-root lexical analyzer hardening | adoption 14p; design-system/adoption/design-sync/typecheck PASS; independent review clean |
| 2026-08-04 | codex/v2-design-system-phase1-primitives | 7e48bcc4c4b395623fbb5334879bdea5480df74d | phase1 lane c primitive maturity and overlays | approved after five bounded fixes; primitive semantics, density, overlays and Tooltip accessibility verified | 17 files/162 tests; follow-up 8/80 and 3/53; Tooltip 41/41; typecheck; design-system/type/icon contracts; independent exact-head review |
Expand All @@ -635,7 +638,6 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie
| 2026-08-04 | codex/v2-design-system-adoption-root | 3cf2d792a1e660a87b0637044837d1c382ff223f | global V2 adoption truth and provenance | approved locally; no P0-P2 findings | Vitest 49 passed; expected 14 declaration mismatches only |
| 2026-08-05 | codex/v2-text-soft-contrast | 6bdda4cee6d702b6bcb7a92899b123595dc42457 | V2 text-role contrast migration | approved locally; no P0-P2 findings | Vitest 85 passed; direct checker 658 files; consumers 0 |
| 2026-08-05 | codex/v2-design-system-completion | 2f9471efaf6596dbb10876f9dc2b865062cdda98 | V2 design-system completion exact-head review | Approved locally; hosted Linux baselines and remote publication remain approval-gated | typecheck pass; lint pass; adoption tests 49 pass; table tests 8 pass; verify:pr-local pass; verify:phone-chrome 116+182+7+349 pass; adoption check expected 14 declaration mismatches |
| 2026-08-04 | codex/fix-mode-switching-and-loading-issues | 3e3b224a2ec13928d1e28173b1fc4c75d202d7d2 | PR #1607 unblock/fix | clean — behind 0, merge-tree clean, 0 unresolved threads, required CI in progress (no code fix) | merge-tree clean; behind_by 0; Unit/Build/Static/ProdUI in progress; no failing required |
| 2026-08-05 | codex/v2-design-system-completion | f12da8239817ae2d6bf99b51d57cb42ad835b6f7 | V2 design-system post-main-sync PR handoff | Approved locally after main sync; hosted Linux evidence remains pending | format pass; diff check pass; protected RAG paths 0; verify pr-local reached full suite with one unchanged timeout; focused timeout rerun 1 pass; prior full UI 349 pass |
| 2026-08-05 | codex/v2-design-system-completion | 8863cea53bf4df59e8795dcaab1fa420b5109516 | PR #1616 v2 design system CI+reviews | fixed typecheck + review defects; baselines remain not-committed by design | tsc; vitest ui-v2/accessible-table/ui-primitives/design-system-adoption |
| 2026-08-05 | codex/v2-design-system-completion | 8b49bfa2b66ed78577b08e1a50414db55898f2df | PR #1616 v2 design system CI+reviews | fixed typecheck + review defects; baselines remain not-committed by design | tsc; vitest ui-v2/accessible-table/ui-primitives/design-system-adoption |
Expand Down
1 change: 1 addition & 0 deletions docs/site-map.md
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,7 @@ This file is generated by `npm run docs:update` (or `npm run sitemap:update` dir
- `/mockups/calculators-popup-sheet` - Route discovered from app directory Source: `src/app/mockups/calculators-popup-sheet/page.tsx`.
- `/mockups/calculators-search` - Route discovered from app directory Source: `src/app/mockups/calculators-search/page.tsx`.
- `/mockups/calculators-search-page` - Route discovered from app directory Source: `src/app/mockups/calculators-search-page/page.tsx`.
- `/mockups/category-filter-directions` - Route discovered from app directory Source: `src/app/mockups/category-filter-directions/page.tsx`.
- `/mockups/document-navigation-contract` - Route discovered from app directory Source: `src/app/mockups/document-navigation-contract/page.tsx`.
- `/mockups/document-navigation-final` - Route discovered from app directory Source: `src/app/mockups/document-navigation-final/page.tsx`.
- `/mockups/document-navigation-final-review` - Route discovered from app directory Source: `src/app/mockups/document-navigation-final-review/page.tsx`.
Expand Down
4 changes: 4 additions & 0 deletions mockups/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ The document-search mockups use generated non-patient bitmap assets in `public/m

Some document-search mockups include live handoff routes (for example `document-search/source-overlays`) that resolve into the real document viewer with a selected page and chunk when indexed data is available locally.

## Category filter directions (phone)

Runnable study at [`/mockups/category-filter-directions`](../src/app/mockups/category-filter-directions/page.tsx): five replacements for the native Category `<select>` blue highlight on Tools (shared `MobileResultFilterControl`). Direction A (soft value button) is shipped as `MobileResultFilterControl`; B (chip rail) remains the alternate.

Comment thread
coderabbitai[bot] marked this conversation as resolved.
## Mode-page redesign comps (2026-07-31)

Static desktop/phone comps for the pages that need redesign (not ModeHome mockups for Favourites) live under [`public/mockups/mode-page-redesign-2026-07/`](../public/mockups/mode-page-redesign-2026-07/README.md):
Expand Down
12 changes: 12 additions & 0 deletions src/app/mockups/category-filter-directions/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import type { Metadata } from "next";

import { CategoryFilterDirectionsMockupsPage } from "@/components/category-filter-directions-mockups";

export const metadata: Metadata = {
title: "Category Filter Directions Mockup - Clinical KB",
description: "Design study: replace the phone Category native-select blue highlight with improved filter patterns.",
};

export default function CategoryFilterDirectionsMockupRoute() {
return <CategoryFilterDirectionsMockupsPage />;
}
5 changes: 5 additions & 0 deletions src/app/mockups/mockups-layout-client.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ export function MockupsLayoutClient({ children }: { children: ReactNode }) {
// Draws its own result bands inside device frames; the shared chrome above
// them would read as a third, real band competing with the two on offer.
const isSearchBandDirectionsMockup = pathname === "/mockups/search-band-directions";
// Renders Tools phone frames with the Category filter under study; shared
// header/composer would read as a second real chrome layer over the frames.
const isCategoryFilterDirectionsMockup = pathname === "/mockups/category-filter-directions";
const isPhoneInPageNavigationMockup = pathname === "/mockups/phone-inpage-navigation";
// Draws its own composer in every frame, and the notice under study is the one
// the shared composer renders — showing both would put two different privacy
Expand Down Expand Up @@ -73,6 +76,7 @@ export function MockupsLayoutClient({ children }: { children: ReactNode }) {
!isCalculatorsSearchPageMockup &&
!isPhoneInPageNavigationMockup &&
!isSearchBandDirectionsMockup &&
!isCategoryFilterDirectionsMockup &&
!isTherapyNavigationMockup &&
!isWarningConsolidationMockup &&
!isWarningLineMockup &&
Expand All @@ -83,6 +87,7 @@ export function MockupsLayoutClient({ children }: { children: ReactNode }) {
!isSearchHeadingMockup &&
!isSearchRefineAdaptiveMockup &&
!isSearchBandDirectionsMockup &&
!isCategoryFilterDirectionsMockup &&
!isPhoneInPageNavigationMockup &&
!isTherapyNavigationMockup &&
!isWarningConsolidationMockup &&
Expand Down
Loading
Loading