-
Notifications
You must be signed in to change notification settings - Fork 0
Ship soft Category filter (replace phone select blue highlight) #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
41b02a0
Add phone category-filter design study mockups
cursoragent 7a9239e
Show open/selected states in category filter mockups
cursoragent 3557862
Merge branch 'main' into cursor/category-filter-mockups-8e31
BigSimmo 5a98a20
Replace phone filter select with soft value button
cursoragent dc2505b
Merge branch 'cursor/category-filter-mockups-8e31' of https://github.…
cursoragent 79e615d
Merge branch 'main' into cursor/category-filter-mockups-8e31
BigSimmo 7aee288
fix(ui): keep phone filter trigger lint-clean and rail-aligned
BigSimmo af4adbc
fix(ui): harden MobileResultFilterControl review findings
cursoragent 055e794
fix(ui): satisfy React purity lint for mobile filter control
cursoragent 0d7dc4c
fix(ui): ignore modifier chords in phone filter typeahead
cursoragent 65c62dc
docs: record PR #1606 babysit review at 0d7dc4c0
cursoragent edfcab5
fix(ui): tighten phone filter geometry and mockup counts
cursoragent a2dd13e
docs: supersede PR #1606 babysit ledger at edfcab5e
cursoragent 20a71e8
fix(ui): let Safari close phone filter by tapping the trigger
cursoragent 7ac98f7
fix(ui): restore trigger focus when closing phone filter by click
cursoragent 2632fca
fix(ui): finish MobileResultFilterControl review gaps
cursoragent 9f44520
Merge remote tip and keep phone-filter review gap fixes
cursoragent bf54a70
fix(ui): ignore disabled filter taps and keep typeahead non-swallowing
cursoragent bccd3ba
merge origin/main: keep soft Category filter menu
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type { Metadata } from "next"; | ||
|
|
||
| import { CategoryFilterDirectionsMockupsPage } from "@/components/category-filter-directions-mockups"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "Category Filter Directions Mockup - Clinical KB", | ||
| description: "Design study: replace the phone Category native-select blue highlight with improved filter patterns.", | ||
| }; | ||
|
|
||
| export default function CategoryFilterDirectionsMockupRoute() { | ||
| return <CategoryFilterDirectionsMockupsPage />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added row is the same
codex/fix-mode-switching-and-loading-issuesrecord that the diff removes from its previous position below, so the commit is rewriting/moving existing ledger history instead of only appending the two newcursor/category-filter-mockups-8e31records. For ledger updates, keep existing rows byte-for-byte in place and append new records only; otherwise future syncs/reviews lose the append-only audit trail this file relies on.AGENTS.md reference: AGENTS.md:L145-L145
Useful? React with 👍 / 👎.