audit fixes (P12): record the seven follow-ups the remediation programme surfaced - #2635
Conversation
Queued through npm run issues:add only; docs/outstanding-issues.md itself is untouched, and these apply on the next npm run issues:reconcile. P1: Caring Contacts validateGovernedMessage has no production caller, so every message-content control the new review pack documents is proof about a function rather than about a delivered message - blocking for a real-patient pilot. P2: patient-plan mockup prints invented mobiles above the fiction-reserved block and the range test cannot see them; the crisis-line re-verification cadence is six months in the new record and twelve in the audit, and the Lifeline and 13YARN numbers carry no source or verification date at all; two high production advisories on main make the dependency audit blocking for any PR touching package.json; the deferred audit findings and what unblocks each; P15's CSRF Origin check has unit coverage only while its browser suite is red; and P20's regenerated Supabase types came from schema.sql rather than the live database with the escapes that hid drift now removed. Verified: check:outstanding-issues in step (73 open, 0 pending). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHSyfuC6mS98ystWFiitAR
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_912108af-aa67-4d4b-b917-21d6ea141328) |
Summary
Audit remediation package P12 — Ledger housekeeping, the package designed to land last. It carries no audit findings of its own; it records what the other twenty packages found and could not close.
Seven requests, queued through
npm run issues:addonly.docs/outstanding-issues.mdis not touched — these apply on the nextnpm run issues:reconcile.The one that is P1
Caring Contacts message-content controls are unreachable.
grep -rn "validateGovernedMessage" src worker scriptsreturns onlymessage-copy.tsand the module itself. Every message-content policy control documented indocs/caring-contacts/message-review-pack.md(added by PR #2626, now merged) is therefore proof about a function, not about a delivered message. Nothing is being sent today, so there is no present risk — but it should be read as blocking for a real-patient pilot, alongside the three unmitigated hazards#1S81R8already names.The six at P2
patient-plan-fixtures.tsprints contacts at0491 570 210–270; the range this repository treats as reserved for fiction ends at156, so some may be real. The range assertion attests/care-plan-domain.test.ts:444runs over a bundle built fromfixtures.tsonly, so it never sees them — the same defect classsdd-ledger.md:623-627records fixing once already. Where the ACMA block actually ends was never verified.message-rules.ts:117carry no source and no verification date anywhere in the repository, and nothing ages them.browserslist,fast-uri) make CI's dependency audit blocking for any PR that touchespackage.json. They are invisible until one does — P3 hit exactly that and had to revert an otherwise-correct dependency declaration. Dependabot PRs chore(deps): bump browserslist from 4.28.2 to 4.28.8 #2568, chore(deps): bump fast-uri from 3.1.5 to 3.1.7 #2570 and the combined chore(deps): combine the fast-uri, xmldom, and browserslist bumps #2616 fix both.L45andL131and the proper@sentry/coredeclaration wait on PR audit fixes (P8a): close the CI, deployment and dependency-supply-chain gaps #2634;L49and P16's drift manifest need tooling this environment cannot run;L5,L126and the calculators governance link need an owner decision.schema.sql, not the live database, and the escapes that previously hid drift are gone, so a drifted column now surfaces at runtime (PR audit fixes (P20): refresh the generated database types and drop the casts that hid the gap #2629).RAG impact: none
Verification
npm run check:ledger-write-discipline—ledger write discipline self-test passed./Ledger write discipline passed for 02a82b2f6951..HEAD.npm run check:outstanding-issues—[snapshot] in step with data/outstanding-issues-snapshot.json (73 open, 0 pending)npm run issues:add. No table row was hand-edited, no existing request changed, no request deleted.Verification not run:
npm run verify:pr-local— this package adds only append-only inbox request files and touches no source, test, workflow or generated file. The two gates above are the ones that govern this change; the heavy gate is left to CI.Verification not run:
npm run verify:ui,npm run verify:release, and every provider-backed gate.Risk and rollout
docs/outstanding-issues-inbox/. No code, no schema, no generated artefact.npm run issues:reconcilefrom a fresh-base branch, which is the only sanctioned way these reachdocs/outstanding-issues.md.Clinical Governance Preflight
unchanged; this package records findings and alters no clinical behaviour.
none introduced or expanded.
Clinical KB Database(sjrfecxgysukkwxsowpy)unchanged; nothing under
supabase/is touched.unchanged.
reinforced — one of the recorded findings is precisely that a mockup's invented phone numbers may fall outside the range reserved for fiction.
unchanged.
reviewed; ledger records only, no decision-support behaviour added.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DHSyfuC6mS98ystWFiitAR
Generated by Claude Code
Note
Low Risk
Append-only documentation queue JSON with no runtime, schema, or dependency changes; canonical ledger updates happen only after reconcile.
Overview
Audit remediation P12 (ledger housekeeping) appends seven version-2
addrequests underdocs/outstanding-issues-inbox/. It does not changedocs/outstanding-issues.mdor application code; those entries apply only after a laternpm run issues:reconcile.The queued items capture open work from the 2026-09-02 audit programme: one P1 issue that
validateGovernedMessagehas no production caller (Caring Contacts policy is not enforced on real sends), plus six P2 items covering patient-plan mockup phone numbers outside the fiction range, crisis-line verification cadence and missing number provenance, blockingnpm auditadvisories onmain, deferred audit findings (ownership/tooling), CSRF Origin check browser coverage, and Supabase types regenerated fromschema.sqlwith drift-escape removals.Reviewed by Cursor Bugbot for commit b336b85. Configure here.