Skip to content

chore: use keyType instead of type for tss + bls keys#2246

Merged
joey-bai merged 1 commit into
masterfrom
BG-43890-tss-keytype-rename
May 3, 2022
Merged

chore: use keyType instead of type for tss + bls keys#2246
joey-bai merged 1 commit into
masterfrom
BG-43890-tss-keytype-rename

Conversation

@joey-bai

@joey-bai joey-bai commented May 2, 2022

Copy link
Copy Markdown
Contributor

type was originally used to differentiate different types of backup keys
(i.e. using an external key provider or holding on to your own).

this was overloaded with the introduction of TSS and BLS.

this change refactors to use keyType to determine multisig type (tss,
bls, or independent/onchain).

Ticket: BG-43890

type was originally used to differentiate different types of backup keys
(i.e. using an external key provider or holding on to your own).

this was overloaded with the introduction of TSS and BLS.

this change refactors to use keyType to determine multisig type (tss,
bls, or independent/onchain).

Ticket: BG-43890
@joey-bai joey-bai requested review from vitalir-bg and wesgraham May 2, 2022 21:56

const { validateParams } = common;

export type KeyType = 'tss' | 'independent' | 'blsdkg';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented May 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2246 (499fdd5) into master (dbdbcfc) will increase coverage by 52.61%.
The diff coverage is n/a.

❗ Current head 499fdd5 differs from pull request most recent head 6cf05f2. Consider uploading reports for the commit 6cf05f2 to get more accurate results

@@             Coverage Diff             @@
##           master    #2246       +/-   ##
===========================================
+ Coverage        0   52.61%   +52.61%     
===========================================
  Files           0        6        +6     
  Lines           0      574      +574     
  Branches        0       94       +94     
===========================================
+ Hits            0      302      +302     
- Misses          0      262      +262     
- Partials        0       10       +10     
Flag Coverage Δ
unit 52.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/express/src/config.ts 94.73% <0.00%> (ø)
modules/express/src/errors.ts 82.35% <0.00%> (ø)
modules/express/src/args.ts 100.00% <0.00%> (ø)
modules/express/src/expressApp.ts 89.51% <0.00%> (ø)
modules/express/src/retryPromise.ts 11.76% <0.00%> (ø)
modules/express/src/clientRoutes.ts 32.48% <0.00%> (ø)

@joey-bai joey-bai requested a review from fperalta-INTIVE May 2, 2022 22:25
@joey-bai joey-bai merged commit 382985d into master May 3, 2022
@joey-bai joey-bai deleted the BG-43890-tss-keytype-rename branch May 3, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants