Skip to content

STLX-15824_add_verify_transaction_in_core_for_near#2248

Merged
ewangbitgo merged 1 commit into
masterfrom
STLX-15824_add_verify_transaction_in_core_for_near
May 6, 2022
Merged

STLX-15824_add_verify_transaction_in_core_for_near#2248
ewangbitgo merged 1 commit into
masterfrom
STLX-15824_add_verify_transaction_in_core_for_near

Conversation

@fmartinAltamirano

@fmartinAltamirano fmartinAltamirano commented May 3, 2022

Copy link
Copy Markdown
Contributor

Add verify transaction in core for Near

@fmartinAltamirano fmartinAltamirano force-pushed the STLX-15824_add_verify_transaction_in_core_for_near branch from 97850db to 02edc65 Compare May 4, 2022 16:03
@codecov

codecov Bot commented May 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2248 (e00ab26) into master (bfa6347) will increase coverage by 85.97%.
The diff coverage is n/a.

❗ Current head e00ab26 differs from pull request most recent head 1fc0f7b. Consider uploading reports for the commit 1fc0f7b to get more accurate results

@@             Coverage Diff             @@
##           master    #2248       +/-   ##
===========================================
+ Coverage        0   85.97%   +85.97%     
===========================================
  Files           0      185      +185     
  Lines           0     9437     +9437     
  Branches        0     1406     +1406     
===========================================
+ Hits            0     8113     +8113     
- Misses          0      839      +839     
- Partials        0      485      +485     
Flag Coverage Δ
unit 85.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/account-lib/src/coin/near/transaction.ts 83.33% <ø> (ø)
...es/account-lib/src/coin/trx/contractCallBuilder.ts 94.52% <0.00%> (ø)
modules/account-lib/src/coin/dot/errors.ts 66.66% <0.00%> (ø)
...les/account-lib/src/coin/trx/transactionBuilder.ts 83.33% <0.00%> (ø)
modules/account-lib/src/coin/algo/index.ts 100.00% <0.00%> (ø)
modules/account-lib/src/coin/baseCoin/iface.ts 100.00% <0.00%> (ø)
...ules/account-lib/src/coin/dot/unnominateBuilder.ts 75.00% <0.00%> (ø)
modules/account-lib/src/coin/algo/txnSchema.ts 86.95% <0.00%> (ø)
modules/account-lib/src/coin/algo/keyPair.ts 88.00% <0.00%> (ø)
...account-lib/src/coin/sol/stakingWithdrawBuilder.ts 97.29% <0.00%> (ø)
... and 176 more

@fmartinAltamirano fmartinAltamirano force-pushed the STLX-15824_add_verify_transaction_in_core_for_near branch 2 times, most recently from 86f1ddf to 3735659 Compare May 5, 2022 17:11
Comment thread modules/bitgo/src/v2/coins/near.ts Outdated
@fmartinAltamirano fmartinAltamirano force-pushed the STLX-15824_add_verify_transaction_in_core_for_near branch from 3735659 to 8333775 Compare May 5, 2022 17:40
Comment thread modules/bitgo/src/v2/coins/near.ts Outdated
Comment thread modules/bitgo/src/v2/coins/near.ts Outdated
@fmartinAltamirano fmartinAltamirano force-pushed the STLX-15824_add_verify_transaction_in_core_for_near branch from 8333775 to 3110e11 Compare May 6, 2022 14:40
@fmartinAltamirano fmartinAltamirano requested a review from alebusse May 6, 2022 14:48
Add verify transaction in core for Near

STLX-15824
@fmartinAltamirano fmartinAltamirano force-pushed the STLX-15824_add_verify_transaction_in_core_for_near branch from 3110e11 to 1fc0f7b Compare May 6, 2022 14:54
Comment thread modules/account-lib/src/coin/near/transaction.ts
@fmartinAltamirano fmartinAltamirano requested a review from alebusse May 6, 2022 15:34
@ewangbitgo ewangbitgo marked this pull request as ready for review May 6, 2022 17:14
@ewangbitgo ewangbitgo requested a review from a team May 6, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants