Skip to content

refactor(account-lib): refactor mpc folder to easily add more curves#2249

Merged
barathcj merged 1 commit into
masterfrom
BG-47401-refactor-mpc-folder-for-easier-addition-of-new-curves-protocols
May 4, 2022
Merged

refactor(account-lib): refactor mpc folder to easily add more curves#2249
barathcj merged 1 commit into
masterfrom
BG-47401-refactor-mpc-folder-for-easier-addition-of-new-curves-protocols

Conversation

@sachushajiabraham

@sachushajiabraham sachushajiabraham commented May 4, 2022

Copy link
Copy Markdown
Contributor

This commit refactors the mpc folder to easily add more curves by defining base interfaces and dedicated files specific to each implementation rather than having everything defined in a single file

TICKET: BG-47401

@codecov

codecov Bot commented May 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2249 (3a6bc3a) into master (7376148) will increase coverage by 85.96%.
The diff coverage is 100.00%.

❗ Current head 3a6bc3a differs from pull request most recent head 3772f8a. Consider uploading reports for the commit 3772f8a to get more accurate results

@@             Coverage Diff             @@
##           master    #2249       +/-   ##
===========================================
+ Coverage        0   85.96%   +85.96%     
===========================================
  Files           0      185      +185     
  Lines           0     9436     +9436     
  Branches        0     1405     +1405     
===========================================
+ Hits            0     8112     +8112     
- Misses          0      839      +839     
- Partials        0      485      +485     
Flag Coverage Δ
unit 85.96% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/account-lib/src/mpc/curves/ed25519.ts 93.54% <100.00%> (ø)
modules/account-lib/src/mpc/curves/index.ts 100.00% <100.00%> (ø)
modules/account-lib/src/coin/xrp/utils.ts 60.00% <0.00%> (ø)
modules/account-lib/src/coin/near/index.ts 100.00% <0.00%> (ø)
modules/account-lib/src/coin/rbtc/resources.ts 100.00% <0.00%> (ø)
...les/account-lib/src/coin/eth/transactionBuilder.ts 90.51% <0.00%> (ø)
...odules/account-lib/src/coin/stx/sendmanyBuilder.ts 76.19% <0.00%> (ø)
...ules/account-lib/src/coin/sol/tokenEncodeDecode.ts 81.66% <0.00%> (ø)
...les/account-lib/src/coin/xrp/transactionBuilder.ts 57.89% <0.00%> (ø)
.../account-lib/src/coin/algo/assetTransferBuilder.ts 87.75% <0.00%> (ø)
... and 176 more

This commit refactors the mpc folder to easily
add more curves by defining
base interfaces and dedicated files specific to
each implementation.

TICKET: BG-47401
@sachushajiabraham sachushajiabraham force-pushed the BG-47401-refactor-mpc-folder-for-easier-addition-of-new-curves-protocols branch from 1e90d6d to 3772f8a Compare May 4, 2022 07:33
@sachushajiabraham sachushajiabraham changed the title refactor(account-lib): refactor mpc folder to easily add more curves and signature schemes refactor(account-lib): refactor mpc folder to easily add more curves May 4, 2022
@sachushajiabraham sachushajiabraham marked this pull request as ready for review May 4, 2022 07:41
@sachushajiabraham sachushajiabraham requested a review from barathcj May 4, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants