chore: github action master to rel/rc#2253
Conversation
ducnguyen-bitgo
left a comment
There was a problem hiding this comment.
I tested the action in my own private repo and it seemed to work correctly. Everything looks good to me!
tylerlevine
left a comment
There was a problem hiding this comment.
I like the idea, but please create a jira for this instead of using BG-00000 so we can track it as part of the sprint. That fake ticket number shouldn't really ever be used and if it is, it should be for quick fixes and not net new features.
Also, is this going to create signed commits? Note that the repo requires all commits to be signed (but a signature from Github is acceptable).
Other than that, just some minor improvement suggestions.
| title: Merge latest to rel/rc | ||
| body: | | ||
| chore: merge latest master to rel/rc | ||
| BG-000000 |
There was a problem hiding this comment.
| BG-000000 |
There was a problem hiding this comment.
I wonder if we can set something up like this? https://github.com/marketplace/actions/jira-create-issue
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| ref: rel/rc |
There was a problem hiding this comment.
I'm confused why we check out rel/rc, then fetch and hard reset to master - why not just check out master directly?
There was a problem hiding this comment.
It came from this example here: https://github.com/peter-evans/create-pull-request/blob/main/docs/examples.md#keep-a-branch-up-to-date-with-another
There was a problem hiding this comment.
I've played around with a few different configurations on a private repo and the current one in the PR is the only one that properly triggers the pull request for me.
b434cb2 to
6c59f9e
Compare
ducnguyen-bitgo
left a comment
There was a problem hiding this comment.
Just left a couple of comments on how the create pull request action plugin should work. Otherwise, everything looks good to me! Btw, I haven't looked at why one of the checks failed.
6c59f9e to
7c520b7
Compare
7c520b7 to
63ac9e8
Compare

Create automatic pull request from
mastertorel/rcwhenevermasteris updated.BG-49173