Skip to content

chore: github action master to rel/rc#2253

Merged
tylerlevine merged 1 commit into
masterfrom
mmcshinsky/auto-pr-relrc
Jun 21, 2022
Merged

chore: github action master to rel/rc#2253
tylerlevine merged 1 commit into
masterfrom
mmcshinsky/auto-pr-relrc

Conversation

@mmcshinsky-bitgo

@mmcshinsky-bitgo mmcshinsky-bitgo commented May 4, 2022

Copy link
Copy Markdown
Contributor

Create automatic pull request from master to rel/rc whenever master is updated.

BG-49173

@mmcshinsky-bitgo mmcshinsky-bitgo marked this pull request as ready for review May 4, 2022 22:17
@mmcshinsky-bitgo mmcshinsky-bitgo requested a review from a team May 24, 2022 21:20
Comment thread .github/workflows/master-to-relrc.yml

@ducnguyen-bitgo ducnguyen-bitgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the action in my own private repo and it seemed to work correctly. Everything looks good to me!

@tylerlevine tylerlevine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but please create a jira for this instead of using BG-00000 so we can track it as part of the sprint. That fake ticket number shouldn't really ever be used and if it is, it should be for quick fixes and not net new features.

Also, is this going to create signed commits? Note that the repo requires all commits to be signed (but a signature from Github is acceptable).

Other than that, just some minor improvement suggestions.

Comment thread .github/workflows/master-to-relrc.yml Outdated
title: Merge latest to rel/rc
body: |
chore: merge latest master to rel/rc
BG-000000

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BG-000000

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can set something up like this? https://github.com/marketplace/actions/jira-create-issue

Comment thread .github/workflows/master-to-relrc.yml Outdated
Comment thread .github/workflows/master-to-relrc.yml Outdated
steps:
- uses: actions/checkout@v3
with:
ref: rel/rc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused why we check out rel/rc, then fetch and hard reset to master - why not just check out master directly?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We could either checkout `rel/rc` or specify it as `base` in `Create Pull Request` (CPR) according to the CPR docs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've played around with a few different configurations on a private repo and the current one in the PR is the only one that properly triggers the pull request for me.

Comment thread .github/workflows/master-to-relrc.yml Outdated

@ducnguyen-bitgo ducnguyen-bitgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of comments on how the create pull request action plugin should work. Otherwise, everything looks good to me! Btw, I haven't looked at why one of the checks failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants