fix(bitgo): attempt to sign using fallback derivation for v1 wallet#2254
Merged
Conversation
We have seen an issue for at least one production v1 wallet where an input is unable to be signed for due to using an incorrect derivation path for the user keychain. We believe this wallet has a non-standard derivation scheme may have been broken in a change to the v1 transaction builder. In the event of a signing failure, try to use a fallback path derivation scheme which we believe will work for the wallet in question. If the fallback path derivation fails, log the error which caused the fallback derivation signing to fail, but throw the original error to maintain previous error behavior. Ticket: BG-46497
Codecov Report
@@ Coverage Diff @@
## master #2254 +/- ##
===========================================
+ Coverage 0 52.61% +52.61%
===========================================
Files 0 6 +6
Lines 0 574 +574
Branches 0 94 +94
===========================================
+ Hits 0 302 +302
- Misses 0 262 +262
- Partials 0 10 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
OttoAllmendinger
approved these changes
May 5, 2022
sangaman
approved these changes
May 5, 2022
sangaman
left a comment
Contributor
There was a problem hiding this comment.
LGTM, interested to see if this resolves the underlying issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen an issue for at least one production v1 wallet where an
input is unable to be signed for due to using an incorrect derivation
path for the user keychain. We believe this wallet has a non-standard
derivation scheme may have been broken in a change to the v1
transaction builder.
In the event of a signing failure, try to use a fallback path derivation
scheme which we believe will work for the wallet in question. If the
fallback path derivation fails, log the error which caused the fallback
derivation signing to fail, but throw the original error to maintain
previous error behavior.
Ticket: BG-46497