Skip to content

fix(statics): change the display of BitGo DAI to SAI to reduce entry errors#2255

Merged
s-soo merged 7 commits into
masterfrom
BG-46702
May 11, 2022
Merged

fix(statics): change the display of BitGo DAI to SAI to reduce entry errors#2255
s-soo merged 7 commits into
masterfrom
BG-46702

Conversation

@s-soo

@s-soo s-soo commented May 5, 2022

Copy link
Copy Markdown
Contributor

TICKET: BG-46702

To reduce transfer entry mistake, the display of BitGo DAI has been changed to (Lumina) SAI, so to differentiate it from BitGo MCDAI (Lumina DAI).

@s-soo s-soo changed the title bug(coin): change the display of BitGo DAI to SAI to reduce entry errors fix(statics): change the display of BitGo DAI to SAI to reduce entry errors May 5, 2022
@s-soo s-soo requested a review from a team May 6, 2022 00:40
@codecov

codecov Bot commented May 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2255 (e88d8b9) into master (3c1ba89) will increase coverage by 86.96%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2255       +/-   ##
===========================================
+ Coverage        0   86.96%   +86.96%     
===========================================
  Files           0      197      +197     
  Lines           0    10799    +10799     
  Branches        0     1573     +1573     
===========================================
+ Hits            0     9391     +9391     
- Misses          0      914      +914     
- Partials        0      494      +494     
Flag Coverage Δ
unit 86.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/statics/src/coins.ts 100.00% <ø> (ø)
...ules/account-lib/src/coin/sol/tokenEncodeDecode.ts 81.66% <0.00%> (ø)
modules/account-lib/src/coin/dot/errors.ts 66.66% <0.00%> (ø)
modules/express/src/config.ts 94.73% <0.00%> (ø)
...t-lib/src/coin/cspr/walletInitializationBuilder.ts 98.03% <0.00%> (ø)
...dules/account-lib/src/coin/rbtc/transferBuilder.ts 100.00% <0.00%> (ø)
...coin/eth/transferBuilder/transferBuilderERC1155.ts 88.67% <0.00%> (ø)
modules/account-lib/src/coin/trx/index.ts 100.00% <0.00%> (ø)
...les/account-lib/src/coin/etc/transactionBuilder.ts 82.60% <0.00%> (ø)
modules/account-lib/src/utils/crypto.ts 94.93% <0.00%> (ø)
... and 188 more

@s-soo s-soo merged commit f55ce6f into master May 11, 2022
@s-soo s-soo deleted the BG-46702 branch May 11, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants