Skip to content

refactor(root): move encoding convertion to fromRawTx for near#2257

Merged
ewangbitgo merged 1 commit into
masterfrom
STLX-16118-account-lib-change-from-to-convert-internally-hex-or-base-64
May 5, 2022
Merged

refactor(root): move encoding convertion to fromRawTx for near#2257
ewangbitgo merged 1 commit into
masterfrom
STLX-16118-account-lib-change-from-to-convert-internally-hex-or-base-64

Conversation

@alebusse

@alebusse alebusse commented May 5, 2022

Copy link
Copy Markdown

Moved the logic to convert from hex to base64 encoding from bitgo(core) to accountLib
Added unit tests

STLX-16118

@alebusse alebusse requested a review from rliberal-simtlix May 5, 2022 15:26
Comment thread modules/account-lib/test/unit/coin/near/transaction.ts Outdated
Moved the logic to convert from hex to base64 encoding from bitgo(core) to accountLib   added unit
tests

STLX-16118
@alebusse alebusse force-pushed the STLX-16118-account-lib-change-from-to-convert-internally-hex-or-base-64 branch from 56c3795 to f668a9a Compare May 5, 2022 15:35
@codecov

codecov Bot commented May 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2257 (f668a9a) into master (bfdc82c) will increase coverage by 85.99%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2257       +/-   ##
===========================================
+ Coverage        0   85.99%   +85.99%     
===========================================
  Files           0      185      +185     
  Lines           0     9437     +9437     
  Branches        0     1406     +1406     
===========================================
+ Hits            0     8115     +8115     
- Misses          0      838      +838     
- Partials        0      484      +484     
Flag Coverage Δ
unit 85.99% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/account-lib/src/coin/near/constants.ts 100.00% <100.00%> (ø)
modules/account-lib/src/coin/near/transaction.ts 83.33% <100.00%> (ø)
modules/account-lib/src/coin/cspr/index.ts 100.00% <0.00%> (ø)
...odules/account-lib/src/coin/dot/transferBuilder.ts 79.74% <0.00%> (ø)
...odules/account-lib/src/coin/stx/sendmanyBuilder.ts 76.19% <0.00%> (ø)
modules/account-lib/src/coin/trx/enum.ts 100.00% <0.00%> (ø)
modules/account-lib/src/coin/hbar/index.ts 100.00% <0.00%> (ø)
...odules/account-lib/src/coin/celo/stakingBuilder.ts 93.33% <0.00%> (ø)
modules/account-lib/src/coin/sol/index.ts 100.00% <0.00%> (ø)
...ount-lib/src/coin/stx/transactionBuilderFactory.ts 80.00% <0.00%> (ø)
... and 177 more

@rliberal-simtlix rliberal-simtlix marked this pull request as ready for review May 5, 2022 15:44
@rliberal-simtlix rliberal-simtlix requested a review from a team May 5, 2022 15:44
@ewangbitgo ewangbitgo merged commit b4dddce into master May 5, 2022
@ericcrosson-bitgo ericcrosson-bitgo deleted the STLX-16118-account-lib-change-from-to-convert-internally-hex-or-base-64 branch May 5, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants