feat(statics): add fiatusd and tfiatusd coins#2261
Conversation
df66e00 to
73b6c39
Compare
73b6c39 to
c46dd7a
Compare
drew-bitgo
left a comment
There was a problem hiding this comment.
All of my comments are strictly formatting, no functional changes. Otherwise I Approve. A few questions for the SDK team, as well.
808d709 to
e78e65e
Compare
e78e65e to
7a6fd7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2261 +/- ##
===========================================
+ Coverage 0 86.13% +86.13%
===========================================
Files 0 198 +198
Lines 0 9686 +9686
Branches 0 1436 +1436
===========================================
+ Hits 0 8343 +8343
- Misses 0 919 +919
- Partials 0 424 +424
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tylerlevine
left a comment
There was a problem hiding this comment.
seems pretty reasonable. Debatably we should not reuse the account convenience function for creating fiat coin instances and should have a separate one. And maybe even a separate child class from BaseCoin altogether. What do you think?
There was a problem hiding this comment.
Careful with the unsafe default here - can this throw MethodNotImplementedError() instead?
There was a problem hiding this comment.
In this case I opt to return the default value since I'm emulating the same behavior as SUSD
7a6fd7f to
804ee94
Compare
Thanks @tylerlevine for your suggestions. I added the new child class and the new factory function to create the Fiat coins. |
add fiatusd and tfiatusd coins to support fiat backing wallets STLX-13382
804ee94 to
1750a43
Compare
Add
fiatusdandtfiatusdcoins to support fiat backing wallets creation.STLX-13382