CT-382: Send BitGoJS version in BitGo Express user agent string#392
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
===========================================
+ Coverage 38.45% 60.79% +22.33%
===========================================
Files 73 74 +1
Lines 9805 9812 +7
Branches 2138 2139 +1
===========================================
+ Hits 3771 5965 +2194
+ Misses 5393 2913 -2480
- Partials 641 934 +293
Continue to review full report at Codecov.
|
dannydeezy
previously approved these changes
Jun 25, 2019
e13953b to
e2d89e0
Compare
e2d89e0 to
ea00776
Compare
dannydeezy
reviewed
Jun 27, 2019
| import { TlsConfigurationError, NodeEnvironmentError } from './errors'; | ||
|
|
||
| const BITGOEXPRESS_USER_AGENT = 'BitGoExpress/' + pjson.version; | ||
| const BITGOEXPRESS_USER_AGENT = `BitGoExpress/${pjson.version} BitGoJS/${version}`; |
Contributor
There was a problem hiding this comment.
do you mean to have a space after ${pjson.version} ?
Contributor
Author
There was a problem hiding this comment.
Yes, this is intentional. It's handled correctly by the user agent parsing code in the backend.
dannydeezy
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.