Skip to content

CT-428 Fix ETH Hop tx gas Estimation#397

Merged
marktoda merged 1 commit into
masterfrom
CT-428-fix-hop-gas-limit
Jun 25, 2019
Merged

CT-428 Fix ETH Hop tx gas Estimation#397
marktoda merged 1 commit into
masterfrom
CT-428-fix-hop-gas-limit

Conversation

@marktoda

@marktoda marktoda commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

The amount being sent can actually have a big impact on the gas used -- we need to pass this through to get a more accurate estimate

See https://github.com/BitGo/platform/pull/805 for the collary platform diff

@codecov

codecov Bot commented Jun 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #397 into master will increase coverage by 22.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #397       +/-   ##
===========================================
+ Coverage   38.39%   60.52%   +22.13%     
===========================================
  Files          71       72        +1     
  Lines        9682     9689        +7     
  Branches     2121     2122        +1     
===========================================
+ Hits         3717     5864     +2147     
+ Misses       5328     2897     -2431     
- Partials      637      928      +291
Flag Coverage Δ
#integration 38.39% <ø> (ø) ⬆️
#unit 54.35% <ø> (?)
Impacted Files Coverage Δ
src/v2/trading/trade.ts 100% <0%> (ø)
src/v2/coins/bsv.ts 35.06% <0%> (+1.29%) ⬆️
src/keychains.ts 34% <0%> (+1.33%) ⬆️
src/v2/coinFactory.ts 94.62% <0%> (+2.15%) ⬆️
src/v2/coins/token.ts 71.52% <0%> (+2.64%) ⬆️
src/util.ts 64.78% <0%> (+2.81%) ⬆️
src/v2/coins/tbch.ts 78.57% <0%> (+3.57%) ⬆️
src/v2/coins/txlm.ts 78.57% <0%> (+3.57%) ⬆️
src/index.ts 96% <0%> (+4%) ⬆️
src/v2/coins/txrp.ts 76% <0%> (+4%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466371b...85adcf1. Read the comment docs.

@twtaylorbitgo twtaylorbitgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marktoda marktoda merged commit e2b6bf0 into master Jun 25, 2019
@0xabrarhussain 0xabrarhussain deleted the CT-428-fix-hop-gas-limit branch October 14, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants