CT-428 Fix ETH Hop tx gas Estimation#397
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
===========================================
+ Coverage 38.39% 60.52% +22.13%
===========================================
Files 71 72 +1
Lines 9682 9689 +7
Branches 2121 2122 +1
===========================================
+ Hits 3717 5864 +2147
+ Misses 5328 2897 -2431
- Partials 637 928 +291
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The amount being sent can actually have a big impact on the gas used -- we need to pass this through to get a more accurate estimate
See https://github.com/BitGo/platform/pull/805 for the collary platform diff