Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

[Hackathon] Add a temporary option for benchmark data.#695

Merged
olupton merged 2 commits into
hackathon_mainfrom
olupton/hackathon/benchmark
Nov 25, 2021
Merged

[Hackathon] Add a temporary option for benchmark data.#695
olupton merged 2 commits into
hackathon_mainfrom
olupton/hackathon/benchmark

Conversation

@olupton

@olupton olupton commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Description
Adds an option CORENRN_EXTERNAL_BENCHMARK_DATA that we can point to a shared directory on Permutter/Ascent/BB5. A draft directory on BB5 is /gpfs/bbp.cscs.ch/project/proj16/olupton/nersc-gpu-hackathon-dec-2021, which exists (possibly out of date) at $CFS/ntrain9/neuron/nersc-gpu-hackathon-dec-2021 on Perlmutter and /ccsopen/proj/gen170/neuron/nersc-gpu-hackathon-dec-2021 on Ascent.

If this is available, building CoreNEURON will also create a special-core binary that can execute the channel-benchmark input data provided in CORENRN_EXTERNAL_BENCHMARK_DATA.

@olupton olupton changed the title Add a hackathon-specific argument for benchmarks. [Hackathon] Add a temporary option for benchmark data. Nov 23, 2021
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Comment thread coreneuron/CMakeLists.txt Outdated

@iomaganaris iomaganaris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one question. How long does this take to run? Should we also include ringtest in case it runs faster? Otherwise for validation of standard functionality I don't think it adds any benefit and we can keep only channel-benchmark

@kotsaloscv kotsaloscv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olupton

olupton commented Nov 25, 2021

Copy link
Copy Markdown
Contributor Author

LGTM Just one question. How long does this take to run? Should we also include ringtest in case it runs faster? Otherwise for validation of standard functionality I don't think it adds any benefit and we can keep only channel-benchmark

On CPU it takes ~8s (setup ~ simulation), on GPU it's ~25s (setup >> simulation, we should fix that 😅) on a Perlmutter node.

I didn't remove anything related to the ringtest, so it's easy to run that too if we want to.

@iomaganaris

Copy link
Copy Markdown
Contributor

LGTM Just one question. How long does this take to run? Should we also include ringtest in case it runs faster? Otherwise for validation of standard functionality I don't think it adds any benefit and we can keep only channel-benchmark

On CPU it takes ~8s (setup ~ simulation), on GPU it's ~25s (setup >> simulation, we should fix that sweat_smile) on a Perlmutter node.

I didn't remove anything related to the ringtest, so it's easy to run that too if we want to.

By setup you mean the NEURON setup or loading the coredat files?

@olupton

olupton commented Nov 25, 2021

Copy link
Copy Markdown
Contributor Author

LGTM Just one question. How long does this take to run? Should we also include ringtest in case it runs faster? Otherwise for validation of standard functionality I don't think it adds any benefit and we can keep only channel-benchmark

On CPU it takes ~8s (setup ~ simulation), on GPU it's ~25s (setup >> simulation, we should fix that sweat_smile) on a Perlmutter node.
I didn't remove anything related to the ringtest, so it's easy to run that too if we want to.

By setup you mean the NEURON setup or loading the coredat files?

Loading the coredat files, which are about 1GB. I think the GPU one is slower because there are currently a lot of tiny unified memory allocations for Random123.

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants