Set persistent global master volume to 20% - #1
Draft
BoLayerDev wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Set the user-level default application master volume to 20%.\n- Apply it before Data:load() so ROM and mod audio begin at the saved level.\n- Add a persistent in-game MASTER VOL control in 5% steps.\n\n## Scope\nUses LÖVE's application mixer only. It does not change Windows/device volume, ROM content, saves, or external PokePath/KFP settings.\n\n## Verification\n- luajit tests/engine/master_volume_options.lua — passed.\n- luajit tests/run_engine.lua — 118/121 suites passed. Existing unrelated failures: �uild_zip_pipe_guard_bug774 (Windows shell scan), quit_thread_shutdown, and itle_zone_seams.