Repository navigation
feat: responsive portrait-first drive-by loadout (#197) - #200
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d6e32d68-6398-4854-9941-c3cbd5b1f688) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Integration caveat under independent review: |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_18dea559-3161-4acd-8efe-97349ecafde0) |
|
Independent review follow-up on head cb8408f: (1) failed stored-photo URLs now set a visible role-art fallback label in both picker and focused manifest; red→green regression added; (2) health with missing maxHealth now shows recorded current health plus “max not recorded,” never a fabricated /100; red→green regression updated. Focused selector 12/12, full frontend 1,033 passed / 4 skipped (91 files), lint 0 errors, typecheck/build/asset audit/package audit green, backend 95 passed. Final real demo 375×812, 390×844, 1440×900 seat→mission replay passes with no CTA/hint overlap or horizontal overflow. #201 separately tracks the legacy engine’s absent named-passenger firing/weapon/reward binding; #197 remains open for that broader acceptance. Await exact new-head GitHub CI and review threads before merge. |
Player outcome
The existing DRIVE app now uses two original GPT Image 2.5 nighttime car/street plates, a responsive DOM HUD, portrait-first seats, member condition and truthful carried-item panels. This is the drive-by loadout, not the separate desktop ATTACK legacy shooter.
Implements the #197 art, seat-eligibility and portrait/HUD slice. Keep #197's broader passenger-firing acceptance open until #201 proves named-member firing and result attribution.
Gameplay contract
DriveByEnginehas not yet received the chosenCarCrew, so bullets are not attributed to individual passengers or carried weapons. This deeper rule is tracked in Bind DRIVE mini-game shots and rewards to passenger shooters, never the driver #201; do not count it complete from selector eligibility.Art and QA
Two prompt-generated original plates, landscape and mobile, were optimized by the merged #199 exact-source asset processor and added to the existing runtime manifest, preserving all 110 existing entries. New WebPs: 138,152 + 201,184 bytes; runtime 7.70 MB of a 20 MB budget. Masters retained outside git in ignored
art-src/.ASSETS.mddocuments provenance. All seat buttons, stats, target search and launch copy are accessible DOM, not baked image text. No founder photograph, private likeness, real address or paid asset committed.Local validation, Node 24, reviewed head
cb8408f: red→green regression cases for driver/passenger roles, stale seat assignment, portrait precedence/fallback (including broken private URLs), real cargo and unknown/max-health data, responsive plate URLs and existing target handoff; focused car selector 12/12. Fullnpm run validatepassed (1,033 frontend tests, 4 skipped; 91 files, lint 0 errors, TypeScript clean, asset audit 0 warnings, package audit);npm run buildpassed; backend pytest 95 passed. Local demo was clicked from the age gate → desktop DRIVE app → select dealer driver + shooter passenger → launch at 375×812, 390×844 and 1440×900. No page exceptions, CTA/hint overlap or horizontal overflow; both plates load from manifest. This proves a local demo path, not authenticated saved-game persistence or a production beta.Deliberately out of scope / launch blockers