Skip to content

Remove Elemental Devastation from spellcrit #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alessandro-Barbieri wants to merge 3 commits into
base: master
Choose a base branch
from
+0 −9
Open

Remove Elemental Devastation from spellcrit #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
699e9bf
Remove Elemental Devastation from spellcrit
Alessandro-Barbieri Aug 5, 2026
e5c50b6
Remove SpellCrit data from Constants.lua
Alessandro-Barbieri Aug 6, 2026
820bb0f
fix spellcrit being counted twice
Alessandro-Barbieri Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Modules/Data/Constants.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,14 +284,6 @@ Data.Aura = {
[25894] = (ECS.IsClassic and 1 or nil), -- Greater Blessing of Wisdom rank 1
[25918] = (ECS.IsClassic and 1 or nil), -- Greater Blessing of Wisdom rank 2
},
SpellCrit = {
[24907] = ((not ECS.IsClassic) and 5 or nil), -- Moonkin Aura
[29177] = 6, -- Elemental Devastation Rank 2
[29178] = 9, -- Elemental Devastation Rank 3
[30165] = 3, -- Elemental Devastation Rank 1
[51466] = 3, -- Elemental Oath Rank 1
[51470] = 5, -- Elemental Oath Rank 2
},
SpellHaste = {
[1714] = -50, -- Curse of Tongues Rank 1
[3603] = -35, -- Distracting Pain
Expand Down
1 change: 0 additions & 1 deletion Modules/Data/SpellCrit.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ function _SpellCrit:GetSpellCritFromBuffs(school)
local aura = C_UnitAuras.GetBuffDataByIndex("player", i)
i = i + 1
if aura and aura.spellId then
mod = mod + (Data.Aura.SpellCrit[aura.spellId] or 0)
if school == Data.FIRE_SCHOOL then
if aura.spellId == 28682 then
mod = mod + (aura.applications * 10) -- 10% for each stack from Combustion
Expand Down
Loading