[Feature]: Sidebar Component - #96
Merged
Merged
Conversation
Share rail layout tokens and collapse rules across React and Vue.
Let collapsed icon rails hide labels without coupling List to Sidebar.
Provide a persistent app-shell rail with provider, inset, and trigger.
Match the React Sidebar shell with provider, inset, and trigger.
Show SidebarProvider composition and how the shell relates to Drawer and List.
Mark the desktop aside inert when offcanvas is collapsed so hidden nav is not focusable.
Nested lists in collapsed sidebar nav should hide labels without repeating the prop.
Keep generic List free of Sidebar context. The wrappers derive iconOnly and tooltips from the nearest rail.
Match nav density, draw a nested guide line, and avoid centering the start slot while the rail shrinks.
Drop expanded color accent, match List row height, and draw a nested guide on the panel without extra padding.
h-svh overflowed bounded previews and hid the account row.
Generic List was styling Listbox and Menu like a rail. Compact rows, nested guides, and tooltip belong on SidebarList/SidebarListItem.
Generic List should not collapse to icons. Rail mode belongs on SidebarList and SidebarListItem.
ListItem always applies px-4. Header and footer rows with secondary used size-8 without resetting that padding, so avatars overflowed the rail.
Explicit tooltip was wrapping expanded and drawer rows. Labels stay visible there, so the overlay is noise.
Token width alone can overflow small phones. Clamp with max-width against 88vw.
The hit wrapper and hasSecondaryLabel were leftovers from icon-only on ListItem.
ListSection should not know the rail. SidebarList provides a generic hidden flag.
The icon-rail hide lived on every AccordionItem. It belongs on the plain panel token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.