Merge C24q4_setup - #7
Merged
Merged
Conversation
nrferguson
reviewed
Oct 23, 2024
nrferguson
reviewed
Oct 23, 2024
nrferguson
reviewed
Oct 23, 2024
nrferguson
requested changes
Oct 26, 2024
nrferguson
left a comment
Collaborator
There was a problem hiding this comment.
I have a few comments and suggestions. The most impactful is to begin using tbmtools.project.connect as the standard protocol for constructing a Modeller object.
nrferguson
force-pushed
the
c24q4_setup
branch
2 times, most recently
from
October 28, 2024 16:05
718762e to
19e9fd2
Compare
nrferguson
approved these changes
Oct 28, 2024
nrferguson
force-pushed
the
c24q4_setup
branch
from
October 28, 2024 18:40
492929f to
189b4ea
Compare
Replace net5I_7c.mac and calculate bus VEQs.
sourceCode parameter added, transit_file_path --> transactionFilePath
Update references in:
* Submit_Full_Regional_Model_SOLA.bat
- install cmap_modedest if flagged
- call TOD_network_prep.py
* create_transit_demand.bat
- remove call to setup_transit_asmt_1_build_transit_asmt_networks.mac
* run_transit_assignment.bat
revised line 124 to: if trnAsmtFlag==1 and rspFlag=="T":
calcUl3_2: explicitly get @pspac for RAIL nodes only
Replace Arterial.Delay
Replace Ftime.Capacity Delete Database/prep_macros/call/Ftime.Capacity replaced by Ftime_capacity.py
nrferguson
force-pushed
the
c24q4_setup
branch
from
October 28, 2024 19:20
189b4ea to
b79487b
Compare
nrferguson
force-pushed
the
c24q4_setup
branch
from
October 29, 2024 18:02
b79487b to
eb8f1a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge c24q4_setup into develop branch. Changes to implement in c24q4 Conformity:
Added
Modified
Deleted