Experimental _get and _get_one typing - #2060
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2060 +/- ##
==========================================
+ Coverage 95.70% 95.72% +0.01%
==========================================
Files 30 30
Lines 9480 9533 +53
Branches 1410 1420 +10
==========================================
+ Hits 9073 9125 +52
Misses 253 253
- Partials 154 155 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@DavidMStraub could check if this actually works for you? |
|
Sorry for the delay! After our discussion, I think the changes are mostly shielded from the user-facing side, but I still think it would be great to get rid of the mypy plugin and make the code base more agnostic of the specific type checker, given modern alternatives like pyright, pyrefly or ty are on the rise. |
Fix param naming Co-authored-by: AU <adam-urbanczyk@users.noreply.github.com>
|
Is the coverage error not a problem? |
… into adam-_get-typing
|
The coverage of this two lines did not change in this PR (i.e. it is a false positive). But fair enough, I extended the tests to get to 100%. |
|
Thanks @adam-urbanczyk |
Gets rid of the mypy plugin. Max arity of
_getand_get_oneis hardcoded, but in practice this should not be a problem.This will possibly enable users of type-checkers other than mypy to use CQ without workarounds.