Conversation
tool4ever
reviewed
Jul 24, 2026
tool4ever
reviewed
Jul 24, 2026
Contributor
|
Connive AI is likely reusable for this mechanic? |
Fix makeTokenTableInternal
fix unused import
tool4ever
approved these changes
Jul 24, 2026
Hanmac
marked this pull request as ready for review
July 24, 2026 07:19
Contributor
Author
Probably |
Tyrathalis
added a commit
to Tyrathalis/forge
that referenced
this pull request
Jul 27, 2026
…-Forge#11355 regression) SpellAbilityEffect.discard() writes the post-move collection back into the map it is handed (discardedMap.put at :906) so its DiscardedAll loop can read it. Upstream 28431f2 ("Recruit: add Effect", Card-Forge#11355, 2026-07-24) changed ConniveEffect to pass an immutable Map.of(...) and gave the new RecruitEffect the same shape, so every connive resolution throws UnsupportedOperationException. Our D4 rebase inherited it. Measured cost before the fix: 28 UnsupportedOperationException crashes in a 4,000-game arms read (0.7%), against 4 in all pre-rebase history, and concentrated in the five pool decks carrying connive cards (Illuminator Virtuoso, Ledger Shredder, Lethal Scheme) — a per-matchup bias, not uniform noise. That read is discarded. ConniveDiscardMapTest pins it, validated failing first (UOE from ConniveEffect:99 via SpellAbilityEffect:906; after: draw one discard one, hand 1 -> 1, graveyard 1). Suite 292 green. FORK-LOCAL AND DELIBERATELY NOT UPSTREAMED: Hanmac has taken responsibility for the regression and is fixing it. No caller of discard() reads the map back, so the maintainer fix (likely: make discard() keep its own local map, which restores Map.of() at the call sites) is behaviorally identical to this one — there is no divergence for the two engines to disagree along. Expect a conflict on these lines at the next rebase and DROP OURS in favour of upstream, the way the Card-Forge#11203 copier fixes came home. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Tyrathalis
added a commit
to Tyrathalis/forge
that referenced
this pull request
Aug 12, 2026
…-Forge#11355 regression) SpellAbilityEffect.discard() writes the post-move collection back into the map it is handed (discardedMap.put at :906) so its DiscardedAll loop can read it. Upstream 28431f2 ("Recruit: add Effect", Card-Forge#11355, 2026-07-24) changed ConniveEffect to pass an immutable Map.of(...) and gave the new RecruitEffect the same shape, so every connive resolution throws UnsupportedOperationException. Our D4 rebase inherited it. Measured cost before the fix: 28 UnsupportedOperationException crashes in a 4,000-game arms read (0.7%), against 4 in all pre-rebase history, and concentrated in the five pool decks carrying connive cards (Illuminator Virtuoso, Ledger Shredder, Lethal Scheme) — a per-matchup bias, not uniform noise. That read is discarded. ConniveDiscardMapTest pins it, validated failing first (UOE from ConniveEffect:99 via SpellAbilityEffect:906; after: draw one discard one, hand 1 -> 1, graveyard 1). Suite 292 green. FORK-LOCAL AND DELIBERATELY NOT UPSTREAMED: Hanmac has taken responsibility for the regression and is fixing it. No caller of discard() reads the map back, so the maintainer fix (likely: make discard() keep its own local map, which restores Map.of() at the call sites) is behaviorally identical to this one — there is no divergence for the two engines to disagree along. Expect a conflict on these lines at the next rebase and DROP OURS in favour of upstream, the way the Card-Forge#11203 copier fixes came home. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Tyrathalis
added a commit
to Tyrathalis/forge
that referenced
this pull request
Aug 21, 2026
…-Forge#11355 regression) SpellAbilityEffect.discard() writes the post-move collection back into the map it is handed (discardedMap.put at :906) so its DiscardedAll loop can read it. Upstream 28431f2 ("Recruit: add Effect", Card-Forge#11355, 2026-07-24) changed ConniveEffect to pass an immutable Map.of(...) and gave the new RecruitEffect the same shape, so every connive resolution throws UnsupportedOperationException. Our D4 rebase inherited it. Measured cost before the fix: 28 UnsupportedOperationException crashes in a 4,000-game arms read (0.7%), against 4 in all pre-rebase history, and concentrated in the five pool decks carrying connive cards (Illuminator Virtuoso, Ledger Shredder, Lethal Scheme) — a per-matchup bias, not uniform noise. That read is discarded. ConniveDiscardMapTest pins it, validated failing first (UOE from ConniveEffect:99 via SpellAbilityEffect:906; after: draw one discard one, hand 1 -> 1, graveyard 1). Suite 292 green. FORK-LOCAL AND DELIBERATELY NOT UPSTREAMED: Hanmac has taken responsibility for the regression and is fixing it. No caller of discard() reads the map back, so the maintainer fix (likely: make discard() keep its own local map, which restores Map.of() at the call sites) is behaviorally identical to this one — there is no divergence for the two engines to disagree along. Expect a conflict on these lines at the next rebase and DROP OURS in favour of upstream, the way the Card-Forge#11203 copier fixes came home. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11280
Api Effect
No new cards yet
no extra Ai yet