Evaluate removing FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS env var and update affected RPC snapshots

[coderabbitai]

Overview

Tracked from PR #7116 (comment: #7116 (comment)) by @hanabi1224.

Evaluate whether the FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS environment variable (introduced in PR #7116 via crate::def_is_env_truthy! in src/state_manager/state_computation.rs) can be removed, and update all affected RPC snapshot tests accordingly.

Motivation

The env var was added as an escape hatch to allow state recomputation on index miss for Eth RPC methods. If this policy can be simplified or the env var is no longer needed, removing it would reduce configuration surface area and complexity.

Affected snapshot tests

The following snapshot tests need to be updated once the env var is removed:

tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethfeehistory_1737446676883828
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethfeehistory_v2_1767605175056660
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockbyhash_1773157415768830
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockbynumber_v2_1768192171057588
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockreceipts_1773157886472662
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockreceipts_v2_1773157886472662
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockreceipts_v2_finalized_1769603486031510
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockreceipts_v2_safe_1769603485649367
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockreceiptslimited_1773157887312363
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetblockreceiptslimited_v2_1773157887312363
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgetlogs_1759922913569082
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgettransactionreceipt_1741272955712904
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethgettransactionreceiptlimited_1741272955611272
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_ethtracefilter_1778490960890609
tool::subcommands::api_cmd::test_snapshot::tests::cargo_test_rpc_snapshot_test_filecoin_getactoreventsraw_1741782590255476

Tasks

• Evaluate whether FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS can be removed
• Remove the env var and associated def_is_env_truthy! usage in src/state_manager/state_computation.rs if appropriate
• Regenerate / update the 15 affected RPC snapshot test fixtures
• Remove the env var entry from docs/docs/users/reference/env_variables.md

[hanabi1224]

Wrong prompt