Add xcresult 3.26 support#53
Merged
Merged
Conversation
mgorkani-cpi
approved these changes
Nov 20, 2020
|
Can spend time to review & release this? We're using Xcode 12 for nowadays |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description: This fixes #50 by adding in the xcresult 3.26 data structures. It also adds back in the userInfo parsing that we removed early on in xcparse creation. This should allow for folks to get info such as the display scale from screenshot attachments. I've made a separate folder for the formatDescriptions so that we can keep track what we've added & make it easier for devs to compare and update when new Xcodes come out.
Test Plan/Testing Performed: Ran the existing unit tests to confirm that parsing is not regressed on them. Need to still add some Xcode 12 xcresults to double-check the new parsing.