IMA-10467 - Add converter from txt to JSON for appthinningreport#57
Closed
vshaweddy-cpi wants to merge 4 commits into
Closed
IMA-10467 - Add converter from txt to JSON for appthinningreport#57vshaweddy-cpi wants to merge 4 commits into
vshaweddy-cpi wants to merge 4 commits into
Conversation
Contributor
Author
|
Scheme settings |
mgorkani-cpi
suggested changes
Apr 13, 2021
| return "\(bytes) bytes" | ||
| case 1_024..<(1_024 * 1_024): | ||
| return "\(String(format: "%.2f", kilobytes)) kb" | ||
| case 1_024..<(1_024 * 1_024 * 1_024): |
Contributor
There was a problem hiding this comment.
shouldn't this be 1_024*1_024
Contributor
Author
There was a problem hiding this comment.
The first condition 1_024..<(1_024 * 1_024) will force the third condition to be (1_024*1_024)..<(1_024 * 1_024 * 1_024). But I also update it to be more concise.
Contributor
|
Picked up these changes and created a new PR #73. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description:
Convert app thinning report.txt to json file
Test Plan/Testing Performed:
Run using xcode