fix: allow lists construction - #397
Merged
cx-lior-poterman merged 3 commits intoSep 16, 2026
Merged
Conversation
cx-julio-silva
previously approved these changes
Sep 10, 2026
cx-julio-silva
approved these changes
Sep 16, 2026
cx-alon-rosenhek
approved these changes
Sep 16, 2026
cx-lior-poterman
deleted the
AST-82620-fix-allow-lists-in-generic-api-key
branch
September 16, 2026 11:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
When we migrated the gitleaks rules to our own code for supporting custom rules, we introduced a method convertAllowLists, part of converting rules to gitleaks rules
The allowlists were being appended together, when they should be independent. This PR fixes this
Checklist
I submit this contribution under the Apache-2.0 license.