Fix Unity license forwarding in builder action#3
Merged
Conversation
Commit by [GitHub Actions](https://github.com/ChronosGames/Actions/actions/runs/29882151487)
Commit by [GitHub Actions](https://github.com/ChronosGames/Actions/actions/runs/29882201911)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UNITY_LICENSEsecrets are not automatically injected into composite actions or forwarded togame-ci/unity-builder@v4by name.Description
unityLicense,unitySerial,unityEmail, andunityPasswordto.github/actions/unity-builder/action.yamlso callers can pass Unity credentials.game-ci/unity-builder@v4usinginputs.* || env.*, and change the masking step to only mask when a serial exists.README.mdexample to showunityLicense: ${{ secrets.UNITY_LICENSE }}and document that organization secrets must be exposed from the calling workflow viawithinputs or jobenv.Testing
ruby -e 'require "yaml"; YAML.load_file(".github/actions/unity-builder/action.yaml")', which succeeded.git diff --checkto ensure there are no whitespace or diff issues, which succeeded.Codex Task