Skip to content

Fix tooltipAutoUpdate targetting the wrong tooltip in AbstractCycleButtonWidget #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brachy84 merged 2 commits into from
Mar 1, 2026
Merged

Fix tooltipAutoUpdate targetting the wrong tooltip in AbstractCycleButtonWidget #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62dcfc5
More like awesome cycle button widget
purebluez Mar 1, 2026
1210966
More like AwesomeTile
purebluez Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/com/cleanroommc/modularui/test/TestTile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,15 @@ public ModularPanel buildUI(PosGuiData guiData, PanelSyncManager syncManager, UI
.reverseLayout(false)
.child(new ToggleButton()
.valueWrapped(cycleStateValue, 0)
.tooltipBuilder(false, t -> {
t.addLine("Wow! This button sure isnt selected! Not one bit!");
if (!this.oversizedStorage.getStackInSlot(this.cycleState).isEmpty()) {
t.addLine("Here is a cool item: ");
t.add(new ItemDrawable(this.oversizedStorage.getStackInSlot(this.cycleState)));
}
})
.tooltipBuilder(true, t -> t.addLine("Wow! This button IS selected! How cool!"))
.tooltipAutoUpdate(true)
.overlay(GuiTextures.CYCLE_BUTTON_DEMO.getSubArea(0, 0, 1, 1 / 3f)))
.child(new ToggleButton()
.valueWrapped(cycleStateValue, 1)
Expand Down
16 changes: 16 additions & 0 deletions src/main/java/com/cleanroommc/modularui/widgets/AbstractCycleButtonWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,22 @@ public W tooltipShowUpTimer(int showUpTimer) {
return getThis();
}

/**
* Sets the tooltip auto update value for all states.
*
* @param update true if tooltips should automatically update
* @return this
*/
@Override
public W tooltipAutoUpdate(boolean update) {
super.tooltipAutoUpdate(update);
expectCount();
for (RichTooltip tooltip : this.tooltip) {
tooltip.setAutoUpdate(update);
}
return getThis();
}

Comment thread
brachy84 marked this conversation as resolved.
protected W stateCount(int stateCount) {
updateStateCount(stateCount, true);
return getThis();
Expand Down