Fix CLI sync command broken after IngestResult refactor - #1
Closed
constkolesnyak wants to merge 1 commit into
Closed
Fix CLI sync command broken after IngestResult refactor#1constkolesnyak wants to merge 1 commit into
constkolesnyak wants to merge 1 commit into
Conversation
- Remove extra `engine` arg passed to `build_source_runners()` (takes 2 args, not 3) - Replace `records_processed`/`records_skipped` with `records_ingested` to match IngestResult dataclass Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
pufit
pushed a commit
that referenced
this pull request
Jun 23, 2026
Notifications sent via NotificationService._deliver_telegram() bypassed TelegramChannel.send() and went directly through bot.send_message(), so they were never stored in _message_cache. When a user reacted to a notification, the reaction handler couldn't find the original text and only showed "[Reaction: 👎]" without context. Now _deliver_telegram caches sent messages via channel._cache_message() so reactions on notifications include the message text. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enginearg passed tobuild_source_runners()which only accepts 2 positional argumentsrecords_processed/records_skippedwithrecords_ingestedto match theIngestResultdataclassTest plan
python -m nerve.cli sync gmail:account@gmail.comruns without errorspython -m nerve.cli sync allworks with multiple sources enabled🤖 Generated with Claude Code