Skip to content

build: pin -std=c11 for instrument-hooks core.c #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
not-matthias wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −2
Open

build: pin -std=c11 for instrument-hooks core.c #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a88d80
build: pin -std=c11 for instrument-hooks core.c
not-matthias Jun 22, 2026
76985b6
build: suppress -Wunterminated-string-initialization for instrument-h…
not-matthias Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,17 @@ instrument_hooks_cflags = [
"-Wno-unused-const-variable",
"-Wno-type-limits",
"-Wno-uninitialized",
# Older Clang lacks -Wunterminated-string-initialization; tolerate the unknown flag.
"-Wno-unknown-warning-option",
"-Wno-unterminated-string-initialization",
# When cross-compiling:
"-Wno-constant-conversion",
"-Wno-incompatible-pointer-types",
"-Wno-unused-function",
]

instrument_hooks_cflags_windows = [
"/std:c11",
"/wd4101", # unreferenced local variable (equivalent to -Wno-unused-variable)
"/wd4189", # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
"/wd4100", # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
Expand All @@ -66,8 +70,8 @@ cc_library(
copts = select({
":windows_strict_warnings": ["/W4","/WX"] + instrument_hooks_cflags_windows,
":windows": instrument_hooks_cflags_windows,
":strict_warnings_enabled": ["-Wall", "-Werror"] + instrument_hooks_cflags,
"//conditions:default": instrument_hooks_cflags,
":strict_warnings_enabled": ["-std=c11", "-Wall", "-Werror"] + instrument_hooks_cflags,
"//conditions:default": ["-std=c11"] + instrument_hooks_cflags,
}),
Comment thread
greptile-apps[bot] marked this conversation as resolved.
visibility = ["//visibility:public"],
)
Expand Down
10 changes: 10 additions & 0 deletions core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ set(instrument_hooks_SOURCE_DIR ${instrument_hooks_repo_SOURCE_DIR})
# Add the instrument_hooks library
add_library(instrument_hooks STATIC ${instrument_hooks_SOURCE_DIR}/dist/core.c)

# Pin C11: the Zig-generated core.c is rejected under C23 (e.g. GCC 15's default),
# which mangles [[noreturn]] placement in the embedded zig.h.
set_target_properties(
instrument_hooks
PROPERTIES C_STANDARD 11 C_STANDARD_REQUIRED ON
)

target_include_directories(
instrument_hooks
PUBLIC
Expand All @@ -47,6 +54,9 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
-Wno-unused-const-variable
-Wno-type-limits
-Wno-uninitialized
# Older Clang lacks -Wunterminated-string-initialization; tolerate the unknown flag.
-Wno-unknown-warning-option
-Wno-unterminated-string-initialization
# When cross-compiling:
-Wno-constant-conversion
-Wno-incompatible-pointer-types
Expand Down
Loading