Skip to content

close server after context succeed #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremygiberson wants to merge 1 commit into from
Closed

close server after context succeed #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,10 @@ function forwardResponseToApiGateway(server, response, context) {
const body = bodyBuffer.toString(isBase64Encoded ? 'base64' : 'utf8')
const successResponse = {statusCode, body, headers, isBase64Encoded}

context.succeed(successResponse)
context.succeed(successResponse);
if (server && server.close) {

@scalebig scalebig Dec 9, 2017 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is closed, but I am dealing with the same. Thoughts using something like:
if(process.env.IS_OFFLINE) { .... }

server.close();
}
})
}

Expand All @@ -98,6 +101,9 @@ function forwardConnectionErrorResponseToApiGateway(server, error, context) {
}

context.succeed(errorResponse)
if (server && server.close) {
server.close();
}
}

function forwardLibraryErrorResponseToApiGateway(server, error, context) {
Expand All @@ -110,6 +116,9 @@ function forwardLibraryErrorResponseToApiGateway(server, error, context) {
}

context.succeed(errorResponse)
if (server && server.close) {
server.close();
}
}

function forwardRequestToNodeServer(server, event, context) {
Expand Down