Remove LogicDict - #28
Merged
Merged
Conversation
Owner
Author
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
worlds.crosscode.types.LogicDictand replace it with a reference to theCrossCodeWorld, greatly simplifying condition code.LogicDicthas a long and storied history. Originally, it was a type to represent the**kwargsthat were sent to condition callbacks, but this quickly became unnecessary and useless as I realized they had no reason to be keyword arguments in the first place. So I changed it into an actual argument to the function. But its existence as aTypedDictcontinued since I could not find a way to pass in the specific combination of world, world data, and options that the type checker would not yell at me for.Turns out the combination of
from __future__ import annotationsandif typing.TYPE_CHECKINGwas all I needed. So this replaces that overgrown legacy construct. I have also added several former entries of theLogicDictclass toCrossCodeWorldinstead.