Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Improve With Precomputing - #220
Open
M-Abdoon wants to merge 1 commit into
Open
Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Improve With Precomputing#220M-Abdoon wants to merge 1 commit into
M-Abdoon wants to merge 1 commit into
Conversation
cjyuan
reviewed
Jul 17, 2026
cjyuan
left a comment
There was a problem hiding this comment.
Can you also use complexity to explain how the new implementation is better than the original implementation?
Comment on lines
+13
to
+20
| sorted_strings = sorted(strings) | ||
| first = sorted_strings[0] | ||
| last = sorted_strings[-1] | ||
| min_length = min(len(first), len(last)) | ||
| i = 0 | ||
| while i < min_length and first[i] == last[i]: | ||
| i += 1 | ||
| return first[:i] |
There was a problem hiding this comment.
The function is expected to return the longest common prefix among all strings in the given array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist