Skip to content

London | May-26 | Liridona Shehu | Sprint 1 | Module-Data-Flow-Destructuring - #501

Closed
shehu-dona wants to merge 3 commits into
CodeYourFuture:mainfrom
shehu-dona:main
Closed

London | May-26 | Liridona Shehu | Sprint 1 | Module-Data-Flow-Destructuring#501
shehu-dona wants to merge 3 commits into
CodeYourFuture:mainfrom
shehu-dona:main

Conversation

@shehu-dona

@shehu-dona shehu-dona commented Jul 29, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

A PR with destructuring arrays and objects exercises.

@github-actions

This comment has been minimized.

Sign in to view
@shehu-dona shehu-dona changed the title London | May-26 | Liridona Shehu | Sprint 1 | Module-Data-Flows London | May-26 | Liridona Shehu | Sprint 1 | Destructuring Jul 29, 2026
@shehu-dona shehu-dona added Module-Data-Flows The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 29, 2026
LonMcGregor
LonMcGregor reviewed Aug 3, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task looks incomplete? Have you comitted and pushed everything?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 3, 2026
@shehu-dona shehu-dona changed the title London | May-26 | Liridona Shehu | Sprint 1 | Destructuring London | May-26 | Liridona Shehu | Sprint 1 | Module-Data-Flow-Destructuring Aug 3, 2026
@shehu-dona

shehu-dona commented Aug 3, 2026

Copy link
Copy Markdown
Author

Hello @LonMcGregor,
I am not sure why the changes are not showing. I committed and pushed to github. In github it shows just the main branch but the changes i made are here:
https://github.com/shehu-dona/Module-Data-Flows/tree/feature/destructuring/Sprint-1/destructuring

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 3, 2026
@LonMcGregor

LonMcGregor commented Aug 4, 2026

Copy link
Copy Markdown

Have a look at the top of this page, can you see which branches you are making a pull request for? Compare that to the link you gave me. You might need to make a new PR with the correct branches.

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 4, 2026
@shehu-dona shehu-dona closed this Aug 4, 2026
@shehu-dona shehu-dona reopened this Aug 4, 2026
@shehu-dona shehu-dona closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

Assignees

No one assigned

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shehu-dona @LonMcGregor @dona-shehu