Skip to content

London | 26-ITP-May | Eyob Zeray | Sprint 2 | course work - #1311

Open
eyob-tech wants to merge 4 commits into
CodeYourFuture:mainfrom
eyob-tech:coursework/sprint-2
Open

London | 26-ITP-May | Eyob Zeray | Sprint 2 | course work#1311
eyob-tech wants to merge 4 commits into
CodeYourFuture:mainfrom
eyob-tech:coursework/sprint-2

Conversation

@eyob-tech

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed debug/address.js, debug/author.js, and debug/recipe.js — corrected property access, object iteration, and array-to-string logging bugs.
  • Implemented implement/contains.js with tests for empty objects, existing/non-existent properties, and invalid input.
  • Fixed implement/lookup.js (was an empty stub) to build a country-to-currency-code object from an array of pairs, with a test added for multiple codes.
  • Fixed implement/querystring.js to correctly split only on the first = per pair, ignore empty key-value pairs, decode percent-encoded characters, and replace + with a space.
  • Fixed implement/tally.js (was an empty stub) to count item frequency in an array and throw on invalid input, with a test added for the empty-array case.
  • Fixed interpret/invert.js to correctly swap object keys and values, with written answers to the interpret questions (a–e) included as comments.

All tests pass locally (npm test).

@eyob-tech eyob-tech added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. 🏕 Priority Mandatory This work is expected labels Jul 27, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Aug 1, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, still some things to work on

Comment thread Sprint-2/implement/tally.test.js
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 1, 2026
@eyob-tech eyob-tech added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 1, 2026
@eyob-tech
eyob-tech requested a review from LonMcGregor August 1, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Groups The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants